Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: only one file has package doc #44

Merged
merged 3 commits into from
May 23, 2023
Merged

doc: only one file has package doc #44

merged 3 commits into from
May 23, 2023

Conversation

smuu
Copy link
Member

@smuu smuu commented May 22, 2023

Closes #20

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

tty47
tty47 previously approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📚

@smuu smuu force-pushed the feature/cleanup-package-doc branch from ed94918 to e0eee80 Compare May 23, 2023 11:57
tty47
tty47 reviewed May 23, 2023
View reviewed changes
pkg/container/buildah.go Outdated Show resolved Hide resolved
tty47
tty47 previously approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a comment, if it's okay, let's move on 🚀

smuu added 2 commits May 23, 2023 15:25
@smuu
doc: only one file has package doc
ecd16b5 
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
@smuu
fix: remove not used file
aa12685 
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
@smuu smuu force-pushed the feature/cleanup-package-doc branch from 0cbaeea to aa12685 Compare May 23, 2023 13:25
@smuu
feat: add doc to docker go file
704d045 
Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>
@smuu smuu requested a review from tty47 May 23, 2023 13:49
tty47
tty47 approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smuu smuu merged commit 25a516f into main May 23, 2023
@smuu smuu deleted the feature/cleanup-package-doc branch May 23, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tty47 tty47 tty47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only one file in a package should have package documentation
2 participants
@smuu @tty47