fix: remove duplicate test parallel

celestiaorg · Sep 4, 2024 · a2877db · a2877db
1 parent 6af8c7b
commit a2877db
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/e2e/system/file_test.go b/e2e/system/file_test.go
@@ -74,13 +74,11 @@ func (s *Suite) TestDownloadFileFromRunningInstance() {
 		namePrefix = "download-file-running"
 	)
 
-	// Setup
-
 	target, err := s.Knuu.NewInstance(namePrefix + "-target")
 	s.Require().NoError(err)
 
 	ctx := context.Background()
-	s.Require().NoError(target.Build().SetImage(ctx, "alpine:latest"))
+	s.Require().NoError(target.Build().SetImage(ctx, alpineImage))
 	s.Require().NoError(target.Build().SetArgs("tail", "-f", "/dev/null")) // Keep the container running
 	s.Require().NoError(target.Build().Commit(ctx))
 	s.Require().NoError(target.Execution().Start(ctx))
@@ -102,14 +100,12 @@ func (s *Suite) TestDownloadFileFromRunningInstance() {
 }
 func (s *Suite) TestDownloadFileFromBuilder() {
 	const namePrefix = "download-file-builder"
-	s.T().Parallel()
-	// Setup
 
 	target, err := s.Knuu.NewInstance(namePrefix + "-target")
 	s.Require().NoError(err)
 
 	ctx := context.Background()
-	s.Require().NoError(target.Build().SetImage(ctx, "alpine:latest"))
+	s.Require().NoError(target.Build().SetImage(ctx, alpineImage))
 
 	s.T().Cleanup(func() {
 		if err := target.Execution().Destroy(ctx); err != nil {
@@ -146,7 +142,7 @@ func (s *Suite) TestMinio() {
 	s.Require().NoError(err)
 
 	ctx := context.Background()
-	s.Require().NoError(target.Build().SetImage(ctx, "alpine:latest"))
+	s.Require().NoError(target.Build().SetImage(ctx, alpineImage))
 	s.Require().NoError(target.Build().SetArgs("tail", "-f", "/dev/null")) // Keep the container running
 	s.Require().NoError(target.Build().Commit(ctx))
 	s.Require().NoError(target.Execution().Start(ctx))

diff --git a/e2e/system/suite_setup_test.go b/e2e/system/suite_setup_test.go
@@ -17,6 +17,7 @@ import (
 const (
 	testTimeout = time.Minute * 15 // the same time that is used in the ci/cd pipeline
 
+	alpineImage             = "alpine:latest"
 	resourcesHTML           = "resources/html"
 	resourcesFileCMToFolder = "resources/file_cm_to_folder"
 )