Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: fix dependency on celestia-app #56

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

tuxcanfly
Copy link
Contributor

@tuxcanfly tuxcanfly commented May 31, 2023

Overview

This PR fixes dependency hell introduced due to celestia-app namespace package in #55

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@tuxcanfly tuxcanfly requested a review from tzdybal May 31, 2023 21:45
@tuxcanfly tuxcanfly requested a review from MSevey May 31, 2023 21:54
@codecov-commenter
Copy link

Codecov Report

Merging #56 (5a17588) into main (e91b08a) will decrease coverage by 17.92%.
The diff coverage is 21.97%.

@@             Coverage Diff             @@
##             main      #56       +/-   ##
===========================================
- Coverage   55.05%   37.14%   -17.92%     
===========================================
  Files           2        3        +1     
  Lines          89      175       +86     
===========================================
+ Hits           49       65       +16     
- Misses         34       97       +63     
- Partials        6       13        +7     
Impacted Files Coverage Δ
namespace.go 18.60% <18.60%> (ø)
client.go 52.38% <80.00%> (ø)

@MSevey MSevey merged commit ec221ef into main May 31, 2023
@MSevey MSevey deleted the tux/fix-celestia-app-dep branch May 31, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants