deps: use celestia-node v0.6.1, celestia-app v0.11.0 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 54.02% 54.02%
=======================================
Files 2 2
Lines 87 87
=======================================
Hits 47 47
Misses 34 34
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nashqueue
requested changes
Dec 16, 2022
| @@ -3,7 +3,7 @@ version: '3' | |||
| services: | |||
| core0: | |||
| container_name: core0 | |||
| image: "ghcr.io/celestiaorg/celestia-app:v0.10.0-rc1" | |||
| image: "ghcr.io/celestiaorg/celestia-app:v0.10.0" | |||
There was a problem hiding this comment.
Regarding Issue #37 Should this be Version 10 or 11 ?
There was a problem hiding this comment.
works with 0.10.0, error 13 with 0.11.0 , so I changed Title
There was a problem hiding this comment.
We need v0.11.0 compatibility, as this is version used by Arabica testnet.
nashqueue
previously approved these changes
Dec 16, 2022
| @@ -3,7 +3,7 @@ version: '3' | |||
| services: | |||
| core0: | |||
| container_name: core0 | |||
| image: "ghcr.io/celestiaorg/celestia-app:v0.10.0-rc1" | |||
| image: "ghcr.io/celestiaorg/celestia-app:v0.10.0" | |||
There was a problem hiding this comment.
works with 0.10.0, error 13 with 0.11.0 , so I changed Title
26329b7 to
2e6cb04
Compare
2e6cb04 to
539d655
Compare
nashqueue
approved these changes
Dec 19, 2022
Manav-Aggarwal
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves: #37
Blocked-by: #40
Checklist