Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use up to date docker images of core and node #34

Merged
merged 2 commits into from
Nov 18, 2022
Merged

ci: use up to date docker images of core and node #34

merged 2 commits into from
Nov 18, 2022

Conversation

tzdybal
Copy link
Member

@tzdybal tzdybal commented Nov 17, 2022 •
edited
Loading

Overview

Resolves #33.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@tzdybal tzdybal self-assigned this Nov 17, 2022
@tzdybal tzdybal added the dependencies Pull requests that update a dependency file label Nov 17, 2022
@tzdybal
ci: use up to date docker images of core and node
7b2e0e9 
* update celestia node to v0.5.0-rc5
* update celestia core to v0.10.0-rc1
* change chain-id to test
* remove fix-genesis.sh (no longer required)
* make start-celestia-appd.sh very similar to
https://github.com/celestiaorg/celestia-app/blob/93f2c71806d6f5aae21fb656c49e15ba3a5a70ed/scripts/single-node.sh
* start-bridge.sh:
  * update celestia node CLI parameters
  * fix order of arguments of `wait-for-it.sh`
@tzdybal
testing: use gateway port in integration tests
e074f0e
@tzdybal tzdybal force-pushed the tzdybal/update_docker branch from 081d2f6 to e074f0e Compare November 17, 2022 22:17
@tzdybal tzdybal changed the title Tzdybal/update docker ci: use up to date docker images of core and node Nov 17, 2022
@tzdybal tzdybal requested review from Manav-Aggarwal, a team, S1nus and jbowen93 and removed request for a team November 17, 2022 22:18
@tzdybal tzdybal marked this pull request as ready for review November 17, 2022 22:19
@tzdybal tzdybal requested a review from MSevey November 17, 2022 22:19
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2022 •
edited
Loading

Codecov Report

Merging #34 (081d2f6) into main (4868ef6) will not change coverage.
The diff coverage is n/a.

❗ Current head 081d2f6 differs from pull request most recent head e074f0e. Consider uploading reports for the commit e074f0e to get more accurate results

@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   54.02%   54.02%           
=======================================
  Files           2        2           
  Lines          87       87           
=======================================
  Hits           47       47           
  Misses         34       34           
  Partials        6        6

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tzdybal tzdybal requested a review from gupadhyaya November 17, 2022 23:00
Manav-Aggarwal
Manav-Aggarwal approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@Manav-Aggarwal Manav-Aggarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzdybal tzdybal merged commit b904798 into main Nov 18, 2022
@tzdybal tzdybal deleted the tzdybal/update_docker branch November 18, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manav-Aggarwal Manav-Aggarwal Manav-Aggarwal approved these changes

@S1nus S1nus Awaiting requested review from S1nus S1nus was automatically assigned from celestiaorg/rollkit

@jbowen93 jbowen93 Awaiting requested review from jbowen93 jbowen93 was automatically assigned from celestiaorg/rollkit

@MSevey MSevey Awaiting requested review from MSevey

@gupadhyaya gupadhyaya Awaiting requested review from gupadhyaya

Assignees

@tzdybal tzdybal

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use compatible docker images in integration test
3 participants
@tzdybal @codecov-commenter @Manav-Aggarwal