New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move striplock to utils package #4046

Closed

crStiv wants to merge 3 commits into celestiaorg:main from crStiv:fix-utils

crStiv commented Jan 15, 2025

This commit moves the striplock implementation to the utils package to make it
more reusable across the codebase. Changes include:

Created new libs/utils/striplock.go with improved implementation
Added comprehensive documentation
Left deprecated type aliases in store package for backward compatibility

crStiv added 3 commits

January 15, 2025 17:52


          Update striplock.go

b3ccdf1


          Create striplock.go

35cf75a


          Update striplock.go

1690c41

crStiv requested review from renaynay, Wondertan, vgonkivs, walldiss and cristaloleg as code owners

January 15, 2025 16:58

github-actions bot added the external label

cristaloleg closed this

Contributor

cristaloleg commented Jan 16, 2025

Thanks for the PR. However, we are not planning such refactoring in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

renaynay Awaiting requested review from renaynay renaynay is a code owner

Wondertan Awaiting requested review from Wondertan Wondertan is a code owner

vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

walldiss Awaiting requested review from walldiss walldiss is a code owner

cristaloleg Awaiting requested review from cristaloleg cristaloleg is a code owner

Labels