Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!(core): remove dependency of RPC in favour of gRPC #3998

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat!(core): remove dependency of RPC in favour of gRPC #3998

wants to merge 5 commits into from

Conversation

vgonkivs
Copy link
Member

The PR adds a gRPC streaming for the block sync for Bridge nodes and enables a secure connection over auth token

@vgonkivs vgonkivs added area:core_and_app Relationship with Core node and Celestia-App kind:break! Attached to breaking PRs kind:misc Attached to miscellaneous PRs labels Dec 11, 2024
@vgonkivs vgonkivs self-assigned this Dec 11, 2024
@vgonkivs vgonkivs marked this pull request as draft December 11, 2024 11:29
@Wondertan Wondertan mentioned this pull request Dec 11, 2024
Merged
@Wondertan
Copy link
Member

Wondertan commented Dec 13, 2024 •
edited
Loading

Reminder to merge this as independent commits

@vgonkivs vgonkivs force-pushed the feature_branch_grpc branch from 15e66a6 to 5326d1b Compare January 15, 2025 11:14
@vgonkivs vgonkivs requested a review from rach-id January 16, 2025 14:14
@vgonkivs vgonkivs marked this pull request as ready for review January 16, 2025 14:14
rach-id
rach-id approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rach-id rach-id rach-id approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@Wondertan Wondertan Awaiting requested review from Wondertan Wondertan is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

@cristaloleg cristaloleg Awaiting requested review from cristaloleg cristaloleg is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@vgonkivs vgonkivs

Labels
area:core_and_app Relationship with Core node and Celestia-App kind:break! Attached to breaking PRs kind:misc Attached to miscellaneous PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vgonkivs @Wondertan @rach-id