-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cmd/blob): add fee and gasLimit flags #2669
feat(cmd/blob): add fee and gasLimit flags #2669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to coordinate around flag structure -
all of our flags are separated by .
instead of -
we should make it consistent. Just noting.
Codecov Report
@@ Coverage Diff @@
## main #2669 +/- ##
==========================================
+ Coverage 51.28% 51.46% +0.17%
==========================================
Files 159 159
Lines 10677 10695 +18
==========================================
+ Hits 5476 5504 +28
+ Misses 4722 4716 -6
+ Partials 479 475 -4
... and 10 files with indirect coverage changes 📢 Have feedback on the report? Share it here. |
thank you @vgonkivs for writing out the examples here 🙌 |
Overview
Added fee and gasLimit flags to submit the blob
Tested on arabica-10:
Checklist
cc @jcstein