Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd/blob): add fee and gasLimit flags #2669

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Sep 7, 2023

Overview

Added fee and gasLimit flags to submit the blob

Tested on arabica-10:

celestia rpc blob submit 0x42690c204d39600fddd3 'gm' --fee 10000
{
  "result": {
    "height": 62559,
    "commitment": "IXg+08HV5RsPF3Lle8PH+B2TUGsGUsBiseflxh6wB5E="
  }
}

celestia rpc blob submit 0x42690c204d39600fddd3 'gm' --fee 10000 --gas.limit 100000
{
  "result": {
    "height": 62561,
    "commitment": "IXg+08HV5RsPF3Lle8PH+B2TUGsGUsBiseflxh6wB5E="
  }
}

celestia rpc blob submit 0x42690c204d39600fddd3 'gm' --gas.limit 100000
{
  "result": {
    "height": 62562,
    "commitment": "IXg+08HV5RsPF3Lle8PH+B2TUGsGUsBiseflxh6wB5E="
  }
}

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

cc @jcstein

ramin
ramin previously approved these changes Sep 7, 2023
Wondertan
Wondertan previously approved these changes Sep 8, 2023
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to coordinate around flag structure -

all of our flags are separated by . instead of -

we should make it consistent. Just noting.

@vgonkivs vgonkivs dismissed stale reviews from Wondertan and ramin via fc163ba September 8, 2023 12:59
@codecov-commenter
Copy link

Codecov Report

Merging #2669 (fc163ba) into main (9957618) will increase coverage by 0.17%.
Report is 4 commits behind head on main.
The diff coverage is 73.68%.

@@            Coverage Diff             @@
##             main    #2669      +/-   ##
==========================================
+ Coverage   51.28%   51.46%   +0.17%     
==========================================
  Files         159      159              
  Lines       10677    10695      +18     
==========================================
+ Hits         5476     5504      +28     
+ Misses       4722     4716       -6     
+ Partials      479      475       -4     
Files Changed Coverage Δ
cmd/celestia/blob.go 17.15% <73.68%> (+7.22%) ⬆️

... and 10 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@vgonkivs vgonkivs added the kind:feat Attached to feature PRs label Sep 8, 2023
@vgonkivs vgonkivs merged commit c650453 into celestiaorg:main Sep 8, 2023
@jcstein
Copy link
Member

jcstein commented Sep 11, 2023

thank you @vgonkivs for writing out the examples here 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rpc kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants