Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixing panic on GetShare with out of bounds indexes #2605

Merged
merged 5 commits into from
Aug 29, 2023
Merged

fix: fixing panic on GetShare with out of bounds indexes #2605

merged 5 commits into from
Aug 29, 2023

Conversation

distractedm1nd
Copy link
Collaborator

GetShare would panic on RPC calls if the passed indicies were out of bounds.

@distractedm1nd distractedm1nd added area:shares Shares and samples kind:fix Attached to bug-fixing PRs labels Aug 24, 2023
@distractedm1nd distractedm1nd self-assigned this Aug 24, 2023
renaynay
renaynay previously approved these changes Aug 24, 2023
View reviewed changes
Wondertan
Wondertan previously approved these changes Aug 24, 2023
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023 •
edited
Loading

Codecov Report

Merging #2605 (2714f3b) into main (196e849) will increase coverage by 0.16%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main    #2605      +/-   ##
==========================================
+ Coverage   51.05%   51.22%   +0.16%     
==========================================
  Files         158      158              
  Lines       10551    10564      +13     
==========================================
+ Hits         5387     5411      +24     
+ Misses       4690     4679      -11     
  Partials      474      474
Files Changed Coverage Δ
share/getter.go 0.00% <ø> (ø)
share/getters/cascade.go 73.33% <50.00%> (+1.71%) ⬆️
share/getters/ipld.go 63.95% <100.00%> (+2.70%) ⬆️
share/getters/store.go 82.89% <100.00%> (+1.46%) ⬆️

... and 9 files with indirect coverage changes

renaynay
renaynay previously approved these changes Aug 24, 2023
View reviewed changes
@renaynay renaynay enabled auto-merge (squash) August 24, 2023 13:09
@renaynay renaynay disabled auto-merge August 24, 2023 13:09
@vgonkivs
Copy link
Member

linter

@distractedm1nd distractedm1nd dismissed stale reviews from renaynay and Wondertan via abc8c70 August 24, 2023 13:41
@distractedm1nd distractedm1nd merged commit 8deffba into main Aug 29, 2023
@distractedm1nd distractedm1nd deleted the getshare-panic branch August 29, 2023 10:43
walldiss pushed a commit to walldiss/celestia-node that referenced this pull request Sep 22, 2023
@distractedm1nd @walldiss
fix: fixing panic on GetShare with out of bounds indexes (celestiaorg…
c2f1a11 
…#2605)

GetShare would panic on RPC calls if the passed indicies were out of
bounds.

(cherry picked from commit 8deffba)
walldiss pushed a commit that referenced this pull request Sep 22, 2023
@distractedm1nd @walldiss
fix: fixing panic on GetShare with out of bounds indexes (#2605)
1b47023 
GetShare would panic on RPC calls if the passed indicies were out of
bounds.

(cherry picked from commit 8deffba)
walldiss pushed a commit that referenced this pull request Sep 25, 2023
@distractedm1nd @walldiss
fix: fixing panic on GetShare with out of bounds indexes (#2605)
ea079bc 
GetShare would panic on RPC calls if the passed indicies were out of
bounds.

(cherry picked from commit 8deffba)
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgonkivs vgonkivs vgonkivs approved these changes

@renaynay renaynay renaynay approved these changes

@Wondertan Wondertan Wondertan left review comments

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@distractedm1nd distractedm1nd

Labels
area:shares Shares and samples kind:fix Attached to bug-fixing PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@distractedm1nd @codecov-commenter @vgonkivs @Wondertan @renaynay