-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(blob): ensure that the share sequence is not empty #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2547 +/- ##
==========================================
- Coverage 51.39% 51.13% -0.27%
==========================================
Files 158 158
Lines 10304 10382 +78
==========================================
+ Hits 5296 5309 +13
- Misses 4556 4609 +53
- Partials 452 464 +12
|
renaynay
approved these changes
Aug 8, 2023
distractedm1nd
approved these changes
Aug 9, 2023
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Aug 9, 2023
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Aug 23, 2023
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 22, 2023
) (cherry picked from commit 3a3473d)
walldiss
pushed a commit
that referenced
this pull request
Sep 22, 2023
(cherry picked from commit 3a3473d)
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 22, 2023
) (cherry picked from commit 3a3473d)
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 25, 2023
) (cherry picked from commit 3a3473d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ensure that the sequence length is not empty.
The issue was randomly found during testing blob retrieval on robusta with @walldiss
Checklist