-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup usage of share.Root
(DAH)
#2481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thank you for this - are we completely sure it's not breaking? I think it still is bc of header field change despite being same underlying type.
Units are also broken @Wondertan |
0ae2ad2
to
6b51fe9
Compare
Codecov Report
@@ Coverage Diff @@
## main #2481 +/- ##
==========================================
- Coverage 51.35% 51.26% -0.10%
==========================================
Files 158 159 +1
Lines 10666 10669 +3
==========================================
- Hits 5478 5469 -9
- Misses 4710 4721 +11
- Partials 478 479 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great cleanup PR!
Somewhere we were using Root and somewhere DAH. Also, we mostly use DAH generator from the app.
These PRs clean up all the usages and localize the Root/DAH type in
share
pkg as was originally intended.Up to discussion is rename of
share.Root
toshare.DAH
to minimize discrepancies between app and node. Alternatively, if we wanna keep Root naming as it is, we should also rename DAH name on the ExtendedHeader(and son tags) and in other places, which is breaking.Now, I think that calling it Root was not right and we should be calling the DataHash type Root, which is in fact the Merkle root of all the shares in the EDS.