feat: new metrics - deployment dashboard #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Codecov Report
@@ Coverage Diff @@
## main #2464 +/- ##
==========================================
+ Coverage 52.48% 52.54% +0.06%
==========================================
Files 156 156
Lines 9995 9995
==========================================
+ Hits 5246 5252 +6
+ Misses 4283 4278 -5
+ Partials 466 465 -1 |
Bidon15
suggested changes
Jul 12, 2023
walldiss
reviewed
Jul 13, 2023
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
Bidon15
reviewed
Jul 17, 2023
tty47
commented
Jul 17, 2023
|
@jrmanes please add |
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
|
@jrmanes please rebase 🙏 |
walldiss
approved these changes
Jul 19, 2023
Wondertan
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello team!
I've added these changes to the code to expose some new metrics via Prometheus client to create the deployment dashboard in Grafana, this new dashboard will include info related to the chains, such as branches/tags, number of nodes, URLs, etc...
I'm using the values generated by the
ldflagsThe dashboard will look like this:
Pending adding the consensus info, it will contain more info
Please, check the code and let me know if you find something to improve, I'll gladly do it 😊
Thanks in advance! 🚀
Jose Ramon Mañes
closes: https://github.com/celestiaorg/devops/issues/401