Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(state): fixing panic when err != nil but response is nil #2339

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

distractedm1nd
Copy link
Collaborator

There was a panic when err != nil but response == nil, for example in the case of: rpc error: code = NotFound desc = account celestia1gchva5av4v798xmqttln9qw9smzrjm2cv2q8e7 not found

2023-06-07T14:20:38.731+0200	ERROR	rpc	go-jsonrpc@v0.3.1/handler.go:276	panic in rpc method 'blob.Submit': runtime error: invalid memory address or nil pointer dereference

@distractedm1nd distractedm1nd added area:state Related to fetching state and state execution kind:fix Attached to bug-fixing PRs labels Jun 7, 2023
@distractedm1nd distractedm1nd self-assigned this Jun 7, 2023
vgonkivs
vgonkivs previously approved these changes Jun 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #2339 (ad8ddf2) into main (b046184) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2339      +/-   ##
==========================================
- Coverage   50.90%   50.88%   -0.03%     
==========================================
  Files         154      154              
  Lines        9746     9746              
==========================================
- Hits         4961     4959       -2     
- Misses       4352     4353       +1     
- Partials      433      434       +1     
Impacted Files Coverage Δ
state/core_access.go 27.53% <0.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cosmos sdk API is very weird and ambiguous sometimes.

@distractedm1nd distractedm1nd merged commit f632908 into main Jun 8, 2023
@distractedm1nd distractedm1nd deleted the coreaccessor-panic branch June 8, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:state Related to fetching state and state execution kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants