-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(share/shrex): improve shrex logging #2101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
added
area:shares
Shares and samples
kind:refactor
Attached to refactoring PRs
labels
Apr 19, 2023
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
April 19, 2023 10:14
walldiss
force-pushed
the
improve_shrex_logs
branch
from
April 19, 2023 10:19
046bf50
to
02f9eb1
Compare
Codecov Report
@@ Coverage Diff @@
## main #2101 +/- ##
==========================================
- Coverage 55.71% 55.68% -0.04%
==========================================
Files 209 209
Lines 13270 13312 +42
==========================================
+ Hits 7394 7413 +19
- Misses 5132 5156 +24
+ Partials 744 743 -1
... and 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Wondertan
reviewed
Apr 19, 2023
renaynay
reviewed
Apr 19, 2023
renaynay
approved these changes
Apr 20, 2023
Wondertan
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #2035