refactoring(share/p2p): remove TTL in pubsub

[vgonkivs]

Overview

Return TTL back to the default value to avoid message duplication with the same msgID.

Checklist

• New and updated code has appropriate documentation
• New and updated code has new and/or updated testing
• Required CI checks are passing
• Visual proof for any user facing features like CLI or documentation updates
• Linked issues closed with keywords

[renaynay]

Can you convert to draft @vgonkivs ? Let's test this first with testground. I'm not sure this resolves the issue.

[Wondertan]

This won't help. Because we never rebroadcast messages in the current code via PubSub means, as we always return ValidarionIgnore. We always rebroadcast via manual Broadcast.

After thinking about this for a while, I think the actual problem is that we send notifications to everyone, including to those from who we already received the notification.

[vgonkivs]

Yeap, I agree that it will not help, but we don't need TTL=0 anyway

[Wondertan]

True, I agree that we can merge it as is. It does not fix the root problem, but it doesn't make it worse and removes a confusion configuration.

[renaynay]

@vgonkivs you can mark ready for review then, just change description

[renaynay]

okya just update the description

[derrandz]

Can you fill me in about the root issue this was supposed to fix?

[Wondertan]

@vgonkivs, pls reference an issue this pr aimed to solve originally