Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add share metrics #1796

Closed
wants to merge 1 commit into from
Closed

Conversation

derrandz
Copy link
Contributor

Overview

This PR adds the following metrics to the share module:

  • node_share_requests_count
  • node_share_request_duration
  • node_share_request_size
  • node_share_eds_size

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@derrandz derrandz self-assigned this Feb 21, 2023
@derrandz derrandz added area:metrics Related to measuring/collecting node metrics area:shares Shares and samples labels Feb 21, 2023
@derrandz derrandz marked this pull request as draft February 21, 2023 16:13
@renaynay
Copy link
Member

What's the update on this PR?

@ramin ramin self-assigned this Sep 5, 2023
@ramin
Copy link
Contributor

ramin commented Sep 5, 2023

@renaynay i'll take this and get cleaned up and ready, unless you feel it should be abandoned?

@distractedm1nd
Copy link
Collaborator

Idk, I think this can be abandoned - we have custom metrics for the individual getters that are more useful, and I dont like the idea of adding yet another wrapping layer to getters.

A better approach would be adding individual metrics to ipld retrieval/IpldGetter, similar to ShrexGetter. We have metrics for the eds store so that's enough for StoreGetter. These implementations have their own interesting metrics and adding an abstraction layer that just counts up isnt very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Related to measuring/collecting node metrics area:shares Shares and samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants