Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(share/discovery): add loop to read events from the channel multiple times #1684

Merged
merged 2 commits into from
Feb 2, 2023
Merged

fix(share/discovery): add loop to read events from the channel multiple times #1684

merged 2 commits into from
Feb 2, 2023

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Feb 2, 2023 •
edited
Loading

Overview

Resolves #1683

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added the kind:fix Attached to bug-fixing PRs label Feb 2, 2023
@vgonkivs vgonkivs self-assigned this Feb 2, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1684 (bf2b03c) into main (897ce1f) will increase coverage by 0.00%.
The diff coverage is 20.00%.

@@           Coverage Diff           @@
##             main    #1684   +/-   ##
=======================================
  Coverage   55.05%   55.05%           
=======================================
  Files         231      231           
  Lines       15032    15033    +1     
=======================================
+ Hits         8276     8277    +1     
  Misses       5874     5874           
  Partials      882      882
Impacted Files Coverage Δ
share/availability/discovery/discovery.go 34.16% <20.00%> (+0.55%) ⬆️
share/ipld/get.go 92.14% <0.00%> (-1.24%) ⬇️
share/eds/byzantine/bad_encoding.go 69.00% <0.00%> (+3.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

renaynay
renaynay approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof :'(

distractedm1nd
distractedm1nd approved these changes Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F

@vgonkivs vgonkivs merged commit 484933e into celestiaorg:main Feb 2, 2023
Wondertan pushed a commit that referenced this pull request Feb 2, 2023
@vgonkivs @Wondertan
fix(share/discovery): add loop to read events from the channel multip…
747c9e5 
…le times (#1684)
vgonkivs added a commit to vgonkivs/celestia-node that referenced this pull request Feb 2, 2023
@vgonkivs
fix(share/discovery): add loop to read events from the channel multip…
4d1a51c 
…le times (celestiaorg#1684)
renaynay pushed a commit to renaynay/celestia-node that referenced this pull request Feb 2, 2023
@vgonkivs @renaynay
fix(share/discovery): add loop to read events from the channel multip…
8eef015 
…le times (celestiaorg#1684)
@renaynay renaynay mentioned this pull request Feb 8, 2023
Merged
renaynay added a commit that referenced this pull request Feb 8, 2023
@renaynay
chore(go.mod): Depend on upstream libp2p (AKA remove hlibp2p) (#1700)
abb9fa1 
As #1684 resolves instability with our bootstrappers, we no longer need
to depend on @Wondertan's fork of libp2p

Related to #1623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaynay renaynay renaynay approved these changes

@Wondertan Wondertan Wondertan approved these changes

@distractedm1nd distractedm1nd distractedm1nd approved these changes

@walldiss walldiss walldiss approved these changes

Assignees

@vgonkivs vgonkivs

Labels
kind:fix Attached to bug-fixing PRs
Projects
No open projects
Celestia Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bugfix(share/discovery): fix subscription handling in discovery
6 participants
@vgonkivs @codecov-commenter @walldiss @distractedm1nd @Wondertan @renaynay