fix(share/discovery): decouple peer discovery from event processing #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e744603 to
78bdfa9
Compare
renaynay
reviewed
Jan 25, 2023
e16fcf5 to
7b4ad0c
Compare
7b4ad0c to
c4f4200
Compare
3 tasks
renaynay
reviewed
Jan 30, 2023
Wondertan
approved these changes
Jan 30, 2023
Codecov Report
@@ Coverage Diff @@
## main #1639 +/- ##
==========================================
+ Coverage 54.91% 54.97% +0.05%
==========================================
Files 231 231
Lines 14995 15010 +15
==========================================
+ Hits 8235 8251 +16
+ Misses 5880 5879 -1
Partials 880 880
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
renaynay
approved these changes
Jan 30, 2023
distractedm1nd
approved these changes
Jan 30, 2023
renaynay
added a commit
to renaynay/celestia-node
that referenced
this pull request
Jan 31, 2023
…elestiaorg#1639) ## Overview Starting to listen to subscriptions async will help us to avoid any blocking in the case when we will not have the needed amount of FNs and will be blocked in `FindPeers`. ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords --------- Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
renaynay
added a commit
that referenced
this pull request
Feb 1, 2023
…1639) ## Overview Starting to listen to subscriptions async will help us to avoid any blocking in the case when we will not have the needed amount of FNs and will be blocked in `FindPeers`. ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords --------- Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Starting to listen to subscriptions async will help us to avoid any blocking in the case when we will not have the needed amount of FNs and will be blocked in
FindPeers.Checklist