Skip to content

Commit

Permalink
fix!: make API version match node version
Browse files Browse the repository at this point in the history
  • Loading branch information
@distractedm1nd
distractedm1nd committed Oct 9, 2023
1 parent d69d3b2 commit 00b32a8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion nodebuilder/node/admin.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"github.com/celestiaorg/celestia-node/libs/authtoken"
)

const APIVersion = "v0.2.2"
const APIVersion = "v0.11.0"

type module struct {
tp Type
Expand Down

1 comment on commit 00b32a8

@ramin
Copy link
Contributor

@ramin ramin commented on 00b32a8 Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@distractedm1nd @Wondertan any reason we don't want to set this dynamically with ldflags, then we don't have to merge for every time we do this? We already set some build info etc

celestia-node/Makefile

Line 5 in 00b32a8

LDFLAGS=-ldflags="-X '$(versioningPath).buildTime=$(shell date)' -X '$(versioningPath).lastCommit=$(shell git rev-parse HEAD)' -X '$(versioningPath).semanticVersion=$(shell git describe --tags --dirty=-dev 2>/dev/null || git rev-parse --abbrev-ref HEAD)'"

? thoughts

Please sign in to comment.