feat!: restrict MaxBytes to values at or below that of MaxSquareSize
#1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
commented
May 12, 2023
Comment on lines
+71
to
+74
| maxBlockBytes := square.EstimateMaxBlockBytes(squareSize) | ||
| if v.MaxBytes > maxBlockBytes { | ||
| return fmt.Errorf("block maximum bytes must be less than or equal to %d: %d", maxBlockBytes, v.MaxBytes) | ||
| } |
There was a problem hiding this comment.
this is consensus breaking, and tbh I'm not really even sure if we should include it since the only real value it provides is throwing an error if people submit a param proposal to change the block size to something that could get above 128 x 128. By doing so, until celestiaorg/celestia-core#1007, we could easily end up producing less efficient squares in some scenarios.
MaxBytes to values at or below that of MaxSquareSize
|
while some of the changes here are ok, this branch mainly introduces a lot of code to simply stop proposals that exceed the max square value. Perhaps its nice to throw an error in that scenario, but its far from necessary and add complexity, so I'm closing this for now. if that's something that we decide we want, then we can reopen |
evan-forbes
commented
May 12, 2023
Comment on lines
+30
to
+52
| // using lots of individual small blobs will result in a large amount of | ||
| // overhead added to the square | ||
| seqs := txsim.NewBlobSequence( | ||
| txsim.NewRange(1, 10000), | ||
| txsim.NewRange(1, 50), | ||
| ).Clone(25) | ||
|
|
||
| ctx, cancel := context.WithTimeout(context.Background(), time.Second*30) | ||
| defer cancel() | ||
|
|
||
| _ = txsim.Run( | ||
| ctx, | ||
| []string{rpcAddr}, | ||
| []string{grpcAddr}, | ||
| kr, | ||
| rand.Int63(), | ||
| time.Second, | ||
| seqs..., | ||
| ) | ||
|
|
||
| // check the block sizes | ||
| blocks, err := testnode.ReadBlockchain(context.Background(), rpcAddr) | ||
| require.NoError(t, err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Leaving as a draft for now until we merge celestiaorg/cosmos-sdk#317 and decide on if this is actually the approach that we want to use to try to limit the square size.
closes #1592 closes #1737
Checklist