.github: fix permissions issue on pr review request on forks #1193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The housingkeeping workflow was failing due to forks not having write access during workflow runs. This is for security reasons. However there are many non-security critical tasks that require write access, such as requesting reviewers or making comments on a PR. For these, the
pull_request_target
trigger can be used, as it allows write access to forks for the select workflows.I tested this on a personal github org and it worked for both native branches and forks.
NOTE: the reason the workflow is not running on this PR is because of the chicken and egg issue of updating workflows, in that the update needs to be on main in order for it to run.
Closes celestiaorg/.github#19
Checklist