Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: fix permissions issue on pr review request on forks #1193

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

MSevey
Copy link
Member

@MSevey MSevey commented Jan 6, 2023

Overview

The housingkeeping workflow was failing due to forks not having write access during workflow runs. This is for security reasons. However there are many non-security critical tasks that require write access, such as requesting reviewers or making comments on a PR. For these, the pull_request_target trigger can be used, as it allows write access to forks for the select workflows.

I tested this on a personal github org and it worked for both native branches and forks.

NOTE: the reason the workflow is not running on this PR is because of the chicken and egg issue of updating workflows, in that the update needs to be on main in order for it to run.

Closes celestiaorg/.github#19

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@MSevey MSevey requested a review from evan-forbes as a code owner January 6, 2023 20:28
@MSevey MSevey requested a review from rootulp January 6, 2023 20:29
rootulp
rootulp previously approved these changes Jan 6, 2023
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

.github/workflows/housekeeping.yml Outdated Show resolved Hide resolved
@MSevey MSevey merged commit 800de23 into main Jan 10, 2023
@MSevey MSevey deleted the sevey/pull_request_target branch January 10, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: PR auto assignment
2 participants