Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reserve the last 256 namespaces for the protocol #2253

Closed
Tracked by #2256
evan-forbes opened this issue Aug 11, 2023 · 2 comments · Fixed by #2257
Closed
Tracked by #2256

Reserve the last 256 namespaces for the protocol #2253

evan-forbes opened this issue Aug 11, 2023 · 2 comments · Fixed by #2257
Assignees
@rootulp
Labels
consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules

Comments

@evan-forbes
Copy link
Member

as originally proposed by @cmwaters, in a similar fashion to how we are reserving the first 256 and the last namespace for the protocol, we should also reserve the last 256 namespaces.
@evan-forbes evan-forbes added consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules and removed needs:triage labels Aug 11, 2023
@evan-forbes evan-forbes mentioned this issue Aug 11, 2023
Closed
7 tasks
@rootulp rootulp self-assigned this Aug 11, 2023
@rootulp rootulp added this to the Mainnet milestone Aug 11, 2023
This was referenced Aug 11, 2023
Merged
Closed
rootulp added a commit that referenced this issue Aug 14, 2023
@rootulp
feat!: reserve the last 256 namespaces for protocol use (#2257)
cb8247e 
Closes #2253
mergify bot pushed a commit that referenced this issue Aug 14, 2023
@rootulp @mergify
feat!: reserve the last 256 namespaces for protocol use (#2257)
25b2df7 
Closes #2253

(cherry picked from commit cb8247e)

# Conflicts:
#	pkg/namespace/consts.go
#	pkg/namespace/namespace.go
#	pkg/namespace/namespace_test.go
#	pkg/shares/padding.go
#	specs/src/specs/namespace.md
rootulp added a commit that referenced this issue Aug 14, 2023
@rootulp
feat!: reserve the last 256 namespaces for protocol use (#2257)
8bd17d3 
Closes #2253
@musalbas
Copy link
Member

What's the rationale for this?

@rootulp
Copy link
Collaborator

rootulp commented Aug 22, 2023 •
edited
Loading

IMO the same reason the protocol reserves namespaces at the beginning of the namespace range. With these two namespace ranges, the protocol can introduce new reserved namespaces that have never been used by applications (a.k.a roll-ups). This is beneficial to avoid a breaking change for applications that would force them to migrate namespaces.

Why is the chunk at the beginning of the namespace range (a.k.a primary reserved namespaces) not sufficient? I think the chunk at the end of the range (a.k.a secondary reserved namespaces) is useful if we want a new reserved namespace to come after all blobs in the ODS (similar to tail padding and parity namespaces).

cmwaters pushed a commit to celestiaorg/go-square that referenced this issue Dec 14, 2023
@rootulp
feat!: reserve the last 256 namespaces for protocol use (#2257)
c63bc2a 
Closes celestiaorg/celestia-app#2253
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp
feat!: reserve the last 256 namespaces for protocol use (#2257)
1db96f7 
Closes celestiaorg/celestia-app#2253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: reserve the last 256 namespaces for protocol use rootulp/celestia-app
3 participants
@rootulp @musalbas @evan-forbes