Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core - PdfPrintSettings change Margins from double to int #3196

Closed
amaitland opened this issue Jul 23, 2020 · 0 comments
Closed

Core - PdfPrintSettings change Margins from double to int #3196

amaitland opened this issue Jul 23, 2020 · 0 comments
Assignees
@amaitland
Labels
breaking-change
Milestone
84.4.x

Comments

@amaitland
Copy link
Member

amaitland commented Jul 23, 2020 •
edited
Loading

Chromium changed the values from double to int and CEF updated accordingly in https://bitbucket.org/chromiumembedded/cef/pull-requests/290

The current double values are being implicitly cast to int.

Marking this as breaking change as the API is changing.
@amaitland amaitland self-assigned this Jul 23, 2020
@amaitland amaitland added this to the 84.3.x milestone Jul 23, 2020
amaitland added a commit that referenced this issue Jul 23, 2020
@amaitland
Core - PdfPrintSettings change Margins from double to int
ac8d922 
Resolves #3196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amaitland amaitland

Labels
breaking-change
Projects
None yet
Milestone
84.4.x
Development

No branches or pull requests
1 participant
@amaitland