Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CleanupElement like CefSharp.Wpf. #14

Merged
merged 3 commits into from
Sep 19, 2021

Conversation

kkwpsv
Copy link
Contributor

@kkwpsv kkwpsv commented Sep 5, 2021

Behave like CefSharp.Wpf.

@kkwpsv
Copy link
Contributor Author

kkwpsv commented Sep 5, 2021

Should I change CleanupElement, when moving this control to another window? CefSharp.Wpf not handle this situation now.

@amaitland
Copy link
Member

Should I change CleanupElement, when moving this control to another window? CefSharp.Wpf not handle this situation now.

Yes, when the presentation source changes if the type is a window.

@kkwpsv kkwpsv requested a review from amaitland September 8, 2021 01:44
@amaitland
Copy link
Member

I don't really have time to test this at the moment, so I'll comment the PresentationSourceChangedHandler changes out for now, you can manually assign CleanupElement in xaml. Changes can be uncommented once they have been further tested.

@amaitland amaitland merged commit bcd74c7 into cefsharp:master Sep 19, 2021
amaitland added a commit that referenced this pull request Sep 19, 2021
Needs testing, have commented out for now.

Follow up to #14
@amaitland amaitland removed their request for review September 19, 2021 04:34
mitchcapper pushed a commit to mitchcapper/_ceftest that referenced this pull request Nov 9, 2024
Needs testing, have commented out for now.

Follow up to cefsharp/CefSharp.Wpf.HwndHost#14
francomattar added a commit to francomattar/HwndHost-CefSharp that referenced this pull request Dec 12, 2024
Needs testing, have commented out for now.

Follow up to cefsharp/CefSharp.Wpf.HwndHost#14
jamesdev9 pushed a commit to jamesdev9/Wpf-HwndHost-CSharp that referenced this pull request Dec 22, 2024
Needs testing, have commented out for now.

Follow up to cefsharp/CefSharp.Wpf.HwndHost#14
NoBrainer242 added a commit to NoBrainer242/CefSharp-Wpf-Hwnd that referenced this pull request Dec 26, 2024
Needs testing, have commented out for now.

Follow up to cefsharp/CefSharp.Wpf.HwndHost#14
NoBrainer242 pushed a commit to NoBrainer242/CefSharp-Wpf-Hwd that referenced this pull request Dec 27, 2024
Needs testing, have commented out for now.

Follow up to cefsharp/CefSharp.Wpf.HwndHost#14
NoBrainer24 added a commit to NoBrainer24/CSharp-Wpf-Hwd-Pr that referenced this pull request Dec 28, 2024
Needs testing, have commented out for now.

Follow up to cefsharp/CefSharp.Wpf.HwndHost#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants