Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E testing #6
E2E testing #6
Changes from all commits
c5d5cf3
7cf54bf
0f4bcb7
3253d49
e7fa5ef
28341bb
4bcd974
cf46e15
84f85a3
366338e
30c74e5
3b20071
425d79c
160821d
bdb2e53
3a8f280
867990a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I've kinda had this conversation before but for Cypress, but I get mildly concerned with (what I think is?) over-DRYing stuff out instead of just using the native APIs inline.
getSomeSelector()
helper for every single new test we add, this file is going to quickly balloon in size and become increasingly difficult to parse/readThis isn't a change request but more a general philosophy that but I'd prefer to keep selector helpers in the file they're used in, and only start DRYing them out to a shared file once more than 2-3+ tests duplicate them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a fair point, thanks.