Cannot select/connect bluetooth device

[manio]

Hi Cedric,
According to the wiki here:
https://github.com/cedricp/ddt4all/wiki/Android-port
I downloaded and installed the latest version there (DOWNLOAD LINK V1.9) -> EcuTweaker-1.9.apk
And it seems this particular version has a bug which leads to problem with connecting to bluetooth devices:
when clicking on Select device button (in bluetooth mode/icon) nothing happens (bluetooth persmission has been granted).

When I downgraded to previous version: EcuTweaker-release-v1.85.apk then all is working just fine.

Maybe this bug was fixed in the mean time (sorry for reporting then), I only want to report this, so you are aware of this problem.

Tested on: Galaxy A10 / Android 11

[Furtif]

latest version is https://github.com/cedricp/ecutweaker/releases/tag/v2.0

[Furtif]

uses debug build

[Furtif]

Fine ??? If ok Close this issue.
Thanks.

[manio]

I have it on my radar.
Please leave it open for a few days, I'll give it a try with newest version ASAP...

[manio]

Hi,
Unfortunately i cannot test the bluetooth because the version 2.0 which you've mentioned is not working for me - it is constantly crashing at startup (Ecu Tweaker keeps stopping: App info/Close app) on my Samsung Galaxy A10 phone. Then I've got notification:
Ecu Tweaker is crashing frequently. Put it in deep sleep to keep your phone running smoothly.

So for me the version which is working great is still: EcuTweaker-release-v1.85.apk

[Furtif]

you uses a good DB ecu-zip ?? try this cedricp/ddt4all#845

[Furtif]

place zip in InternalStorage root

[Furtif]

can't not unzip place as zip

[Furtif]

and not uses Release apk uses the EcuTweaker-debug.apk apk release apk is bugued

[manio]

Yes, this is the database I am using. It's md5 is exactly:
57d9856cf2959b387c408867cb32dfdf ecu.zip
I know how to use it because the earlier version is working fine (with the same ecu.zip)

I will now try the debug version...

[manio]

Ok ... the debug version started fine!
... but the bluetooth bug is still there. I am clicking on SELECT DEVICE and nothing happen.

When I change eg for USB, then button is doing action (eg EcuTweaker USB scan).

[Furtif]

i think issue in release mode is because obfucation mode https://github.com/cedricp/ecutweaker/blob/master/EcuTweaker/build.gradle#L46

for bluethoo maybe you need associate device before in android settings>conexions->bluethoot

[manio]

I had the device paired before app start (and it is working without any problems on older versions). The bug probably started between version 1.85 and 1.9.

[Furtif]

@manio try new release https://github.com/cedricp/ecutweaker/releases/tag/v2.1

release or debug normally, both are ok, I tested and the bluethood devices already appear.

[manio]

Thanks, I've installed this 2.1 release version and unfortunately no change - clicking on "Select device" -> no action.

[Furtif]

@manio
Here is my apk if you want to test it now, be careful all the required permissions are not requested at the first start of the application, has been tested on a Galaxy S9 with Android 14.
https://drive.proton.me/urls/0J536C04C0#opd8CcKXlCQC

Pr change if you want please.

[Furtif]

But I thinks have same issue in recent android, I have changed to this because warn in sdk recent

[Furtif]

I added a location permission request for older androids, on the android studio emulator I used a phone with android 11, which had the error where nothing happened after the click, but now it seems to work. On my emulator the storage permission is not displayed and I did not try to update the requests so make sure to authorize it manually. Here is the apk to see if everything works correctly https://drive.proton.me/urls/E8WPQS7JFW#HkM8jJEipe2o

PR you changes

• or propose

[Furtif]

Sorry I have never used github except to download codes, I don't know how it works.

Here is the modified code in MainActivity.java

void selectDevice(){
        BluetoothAdapter bluetoothAdapter = BluetoothAdapter.getDefaultAdapter();

        // If the adapter is null, then Bluetooth is not supported
        if (bluetoothAdapter == null) {
            return;
        }

        if (bluetoothAdapter.isEnabled()) {
            stopConnectionTimer();
            try {
                if (mLinkMode == LINK_BLUETOOTH) {
                    // ajout perso \/
                    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
                        // Android 12 (31) +
                        if (!askBluetoothScanPermission()) {
                            return;
                        }
                    } else {
                        // Android 11 (30) -
                        if (ContextCompat.checkSelfPermission(this, Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED) {
                            ActivityCompat.requestPermissions(this, new String[]{Manifest.permission.ACCESS_FINE_LOCATION}, REQUEST_PERMISSION_LOCATION);
                            return;
                        }
                    }
                    // ajout perso /\
                    
                    Intent serverIntent = new Intent(this, DeviceListActivity.class);
                    startActivityForResult(serverIntent, REQUEST_CONNECT_DEVICE);
                } else if (mLinkMode == LINK_USB) {
                    Intent serverIntent = new Intent(this, UsbDeviceActivity.class);
                    startActivityForResult(serverIntent, REQUEST_CONNECT_DEVICE);
                }
            } catch (android.content.ActivityNotFoundException e) {

            }
        }
    }

ok send me you change in discord https://discord.gg/HPvvSa8J

[Furtif]

send me you files changed i go change it at a pr for test

[Furtif]

@manio https://github.com/cedricp/ecutweaker/actions/runs/12188586212 thanx to @haiku255 , you test it please ?

[Furtif]

@haiku255 thank for #14 , now need test for look

[manio]

@Furtif I tested the last artifact (release):
Yeah!!! It's finally working back!!!!!
For the first time it was asking for permission, second click is giving me a list of Bluetooth devices!

Thank you @haiku255 for your work!

[Furtif]

@Furtif I tested the last artifact (release): Yeah!!! It's finally working back!!!!! For the first time it was asking for permission, second click is giving me a list of Bluetooth devices!

Thank you @haiku255 for your work!

is fine ??? but in pixel5 a14 not work !

[Furtif]

but ok go merge if ok and close this

[Furtif]

@manio test new release https://github.com/cedricp/ecutweaker/releases/tag/v2.2

[manio]

@Furtif
Confirm, working OK! :)

Thank you all involved!

[Furtif]

Click Mark as answer

[Furtif]

@manio join https://discord.gg/cBqDh9bTHP

[Furtif]

@Furtif Confirm, working OK! :)

Thank you all involved!

cool read and test #18

[igogo2]

Unfortunately for me doesn't fixed. Selecting work but connecting not.
I've tested four versions 2.2 and 2.3 (release and debug) on two phones (Android 9 and 10).
After clicking "Select device" button with Bluetooth "Paired devices" window opened correctly and showed my ELM. After clicking on it the window closes but pictogram still show "unconnected" and "Auto identify" doesn't work.
How could i provide any additional (debug) information for identifying the problem?

[Furtif]

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) to if (Build.VERSION.SDK_INT > Build.VERSION_CODES.S)

[Furtif]

if not ok issue is in this https://github.com/cedricp/ecutweaker/blob/master/EcuTweaker/src/main/java/org/quark/dr/canapp/MainActivity.java#L704 i need maybe make that (all in one android 11 > up) or bypass id < 11...

[Furtif]

hum go look if i make a better conditional .

[Furtif]

but ODDD you have acepted LOCATION permition ? in A9-10 bluethood is Croate_Location you have Acepted ? IF not sure please uninstall app reinstall and accordings premitions.

[igogo2]

I accepted all 2 permissions Location and Storage Before first run of application.

[manio]

@igogo2
Oooops... I didn't check that... I was only focusing on "device selection" window which was not working and eventually has been fixed.
Ok... but is it working fine for you in "known-good" version 1.85?

[Furtif]

@manio issues ?? for my side wifi + usb all right

[Furtif]

🤷🏻‍♂️

[manio]

@Furtif
Unfortunately @igogo2 is right! It is not connecting also for me. As I said i was focusing to test the selection dialog but I didn't testing it on real device. Now I tested some recent versions and:
1.85 - still working OK (showing dialog and connecting)
2.3 and your last artifact - showing bluetooth device selection dialog but then it is not connecting :(

I also can see that old version when I connected for the first time asked if I want to Pair. New versions seems is doing nothing - not asking and not doing anything - similar as was with "Select device" button.

The problem is visible like this:
old version: clicking on red "⛓️‍💥" symbol: asking for pairing, connect and the icon is green (connected)
new versions: clicking on red "⛓️‍💥" symbol is doing nothing = no action (like it was with "select device" before)

All tests done on Android 11 (Samsung Galaxy A10)

[Furtif]

🤷🏻‍♂️🤔🤔🧐 odd, Clicking on the icon normally doesn't work, I think this is just the connection status, as I said in discord.

[igogo2]

@igogo2 try last artifact https://github.com/cedricp/ecutweaker/actions/runs/12569822757/artifacts/2376139502
Doesn't work.