Fix JSON Serializer generating json with attributes with a null value #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of checking that its value is `nil` which will return true even if the key is not included in the hash.
In Rails, `nil` responds to `as_json` therefore the attributes whose value is `nil` are added to the result of `as_json`, which may end up causing issues with some authenticators – see #441. This commits adds another condition to the if in order to prevent this from happening.
brauliomartinezlm
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #441.
In Rails,
nilresponds toas_jsontherefore the attributes whose value isnilare added to the result ofas_json, which may end up causing issues with some authenticators – as described in the associated issue.This PR attempts to fix this by adding another condition to the if to skip if the value for the attribute is
nil.