Lean: Definitions and theorems for duration
converters
#578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: #527 missed the converter "methods" associated to the
duration
type, as specified in the RFC for the datetime extension:.toMilliseconds()
returns along
describing the number of milliseconds in this duration (the value as a long, itself).toSeconds()
returns along
describing the number of seconds in this duration (.toMilliseconds() / 1000
).toMinutes()
returns along
describing the number of minutes in this duration (.toSeconds() / 60
).toHours()
returns along
describing the number of hours in this duration (.toMinutes() / 60
).toDays()
returns along
describing the number of days in this duration (.toHours() / 24
)We include unit tests for each method in addition to a type call theorem for all of them.
The changes also include fixes for an embarrassing mistake in the
MILLISECONDS_PER_HOUR
definition.