Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue in Datetime.Duration.parse when parsing min duration #577

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

chaluli
Copy link
Contributor

@chaluli chaluli commented Mar 11, 2025

There is a bug in the current Duration.parse which prevented the successful parsing of durations that represented -9223372036854775808ms

…min duration (e.g., "-9223372036854775808ms")

Signed-off-by: Charlie Murphy <mutmoth@amazon.com>
Copy link
Contributor

@adpaco-aws adpaco-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@chaluli chaluli merged commit 1b6649e into cedar-policy:main Mar 11, 2025
6 checks passed
@chaluli chaluli deleted the duration_parse_fix branch March 11, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants