Remove the log feature
#575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Palacios <accorell@amazon.com>
cdisselkoen
approved these changes
Mar 10, 2025
cdisselkoen
reviewed
Mar 10, 2025
Signed-off-by: Adrian Palacios <accorell@amazon.com>
katherine-hough
approved these changes
Mar 10, 2025
john-h-kastner-aws
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: Remove the
logfeature, and theSerializeimplementations it required for all fuzz targets.Context: We recently discovered that the
logfeature was being used in DRT, but it's mostly undocumented and we estimate it's not so useful since we don't log most of the input (see this conversation). We've stopped using--features login DRT so we can get rid of the feature in addition to theSerializeimplementations we didn't want to restore in the Cedar API.