Skip to content

Commit

Permalink
fix: retry trakt requests when needed
Browse files Browse the repository at this point in the history
  • Loading branch information
cecobask committed Jun 3, 2024
1 parent 1d03633 commit 7fec016
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
7 changes: 7 additions & 0 deletions pkg/client/trakt.go
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,13 @@ func (tc *TraktClient) doRequest(requestFields requestFields) (*http.Response, e
tc.logger.Warn(message)
time.Sleep(duration)
continue
case http.StatusRequestTimeout, http.StatusBadGateway, http.StatusServiceUnavailable, http.StatusGatewayTimeout:
response.Body.Close()
duration := time.Second
message := fmt.Sprintf("unexpected status code %d, waiting for %s then retrying http request %s %s", response.StatusCode, duration, response.Request.Method, response.Request.URL)
tc.logger.Warn(message)
time.Sleep(duration)
continue
default:
response.Body.Close()
return nil, &ApiError{
Expand Down
19 changes: 19 additions & 0 deletions pkg/client/trakt_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,25 @@ func TestTraktClient_doRequest(t *testing.T) {
assertions.Contains(err.Error(), "reached max retry attempts")
},
},
{
name: "handle retryable status",
args: args{
requestFields: dummyRequestFields,
},
requirements: func(requirements *require.Assertions) *httptest.Server {
handler := func(w http.ResponseWriter, r *http.Request) {
requirements.Equal(dummyRequestFields.Method, r.Method)
requirements.Equal(dummyRequestFields.Endpoint, r.URL.Path)
w.WriteHeader(http.StatusBadGateway)
}
return httptest.NewServer(http.HandlerFunc(handler))
},
assertions: func(assertions *assert.Assertions, res *http.Response, err error) {
assertions.Nil(res)
assertions.Error(err)
assertions.Contains(err.Error(), "reached max retry attempts")
},
},
{
name: "handle unexpected status code",
args: args{
Expand Down

0 comments on commit 7fec016

Please sign in to comment.