Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new separate terraform plans for staging and production #309

Merged
merged 18 commits into from
Nov 1, 2021
Merged

add new separate terraform plans for staging and production #309

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e09154d
add new terraform plan for staging
sastels Oct 29, 2021
6e0479f
Merge branch 'main' into new-terraform-plan-action
sastels Oct 29, 2021
c3fd7d4
bump the terragrunt version
sastels Oct 29, 2021
698a79d
poke lambda to trigger action
sastels Oct 29, 2021
ebb40f6
fix Max's hackery
sastels Oct 29, 2021
73e4909
revert lambda poke and fix formatting :sweat_smile:
sastels Oct 29, 2021
67edcd5
delete unused variable
sastels Oct 29, 2021
e205d05
add production terraform plan workflow
sastels Oct 29, 2021
c1ae978
add infrastructure_version maybe
sastels Oct 29, 2021
64adb9e
this might work
sastels Oct 29, 2021
c51a774
fix names in prod plan
sastels Oct 29, 2021
1ef19f5
run the plan for common too
sastels Oct 29, 2021
33cc1be
add missing variables
sastels Oct 29, 2021
4cd15da
only run prod plan if infrastructure version changes
sastels Oct 29, 2021
6e42513
fix typo in prod plan
sastels Oct 29, 2021
261e89a
add varaiable to stop recreating the slack lambdas
sastels Nov 1, 2021
366561b
Merge branch 'main' into new-terraform-plan-action
sastels Nov 1, 2021
b3a378f
Merge branch 'main' into new-terraform-plan-action
sastels Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
delete unused variable
  • Loading branch information
@sastels
sastels committed Oct 29, 2021
commit 67edcd57113dbaae39861688a254387cb8b72008
4 changes: 0 additions & 4 deletions aws/rds/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ variable "kms_arn" {
type = string
}

variable "rds_server_db_user" {
type = string
}

Comment on lines -9 to -12
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable is not used in the code. It was added in #282 where it was briefly used, but in the end the code that used it was deleted from the PR in 8b36b21 (it was in the secrets.tf file that was deleted in that commit)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning it up.

variable "rds_cluster_password" {
type = string
sensitive = true
Expand Down