Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated anatomy images #463

Merged
merged 3 commits into from
Jan 22, 2025
Merged

updated anatomy images #463

merged 3 commits into from
Jan 22, 2025

Conversation

nmakuch
Copy link
Contributor

@nmakuch nmakuch commented Jan 21, 2025

Summary | Résumé

Components to be updated:

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-463.d35vdwuoev573o.amplifyapp.com

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-463.djtlis5vpn8jd.amplifyapp.com

Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great, except for the one FR anatomy that is currently loading an anatomy with EN content.

@SmartMouthWords for some of these anatomies we are changing the content of the anatomy image like for the error summary for example which means, the anatomy content will not match the preview component content anymore. Is that ok or do we want the preview content to be the same as the anatomy content for each component?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops looks like this is the EN anatomy and not the FR anatomy. Can we switch this for the FR anatomy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, yep just updated 👌🏽

@nmakuch nmakuch requested a review from melaniebmn January 22, 2025 02:32
Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmakuch nmakuch merged commit 34c4b79 into main Jan 22, 2025
3 checks passed
@nmakuch nmakuch deleted the typo-anatomy-image-update branch January 22, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants