feat(NagPack)!: Rule name consistency and system simplification #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and moving rules to shared folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While functionality has not changed, this PR is flagged as breaking as it updates the various Config Rule related packs to have consistent rule names.
This PR simplifies the testing and rule creation system to make it easier to use rule across packs and to create new packs. Rule Ids are now comprised of a prefix (Pack Name) and suffix (Rule Name). Rules now have default names that can optionally be overwritten on a per-pack basis. This provides a more consistent experience for those who are using multiple packs for testing as the same rule will no longer have different suffixes across packs
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license