-
Notifications
You must be signed in to change notification settings - Fork 69
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(HIPAA Security): ECS check (#344)
Closes #243 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information
Showing
5 changed files
with
231 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
src/HIPAA-Security/rules/ecs/hipaaSecurityECSTaskDefinitionUserForHostMode.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /* | ||
| Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
| import { CfnTaskDefinition, NetworkMode } from '@aws-cdk/aws-ecs'; | ||
| import { IConstruct, Stack } from '@aws-cdk/core'; | ||
|
|
||
| /** | ||
| * Containers in ECS task definitions configured for host networking have 'privileged' set to true and a non-empty non-root 'user' - (Control IDs: 164.308(a)(3)(i), 164.308(a)(3)(ii)(A), 164.308(a)(4)(ii)(A), 164.308(a)(4)(ii)(C), 164.312(a)(1)) | ||
| * @param node the CfnResource to check | ||
| */ | ||
| export default function (node: IConstruct): boolean { | ||
| if (node instanceof CfnTaskDefinition) { | ||
| if (node.networkMode === NetworkMode.HOST) { | ||
| const containerDefinitions = Stack.of(node).resolve( | ||
| node.containerDefinitions | ||
| ); | ||
| if (containerDefinitions !== undefined) { | ||
| for (const containerDefinition of containerDefinitions) { | ||
| const resolvedDefinition = | ||
| Stack.of(node).resolve(containerDefinition); | ||
| const privileged = Stack.of(node).resolve( | ||
| resolvedDefinition.privileged | ||
| ); | ||
| const user = Stack.of(node).resolve(resolvedDefinition.user); | ||
| if (privileged !== true || user === undefined) { | ||
| return false; | ||
| } | ||
| const rootIdentifiers = ['root', '0']; | ||
| const userParts = user.split(':'); | ||
| for (const userPart of userParts) { | ||
| if (rootIdentifiers.includes(userPart.toLowerCase())) { | ||
| return false; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| return true; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,163 @@ | ||
| /* | ||
| Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import { SynthUtils } from '@aws-cdk/assert'; | ||
| import { | ||
| TaskDefinition, | ||
| Compatibility, | ||
| NetworkMode, | ||
| EcsOptimizedImage, | ||
| } from '@aws-cdk/aws-ecs'; | ||
| import { Aspects, Stack } from '@aws-cdk/core'; | ||
| import { HIPAASecurityChecks } from '../../src'; | ||
|
|
||
| describe('Amazon Elastic Container Service (Amazon ECS', () => { | ||
| test("hipaaSecurityECSTaskDefinitionUserForHostMode: - Containers in ECS task definitions configured for host networking have 'privileged' set to true and a non-empty non-root 'user' - (Control IDs: 164.308(a)(3)(i), 164.308(a)(3)(ii)(A), 164.308(a)(4)(ii)(A), 164.308(a)(4)(ii)(C), 164.312(a)(1)).", () => { | ||
| const nonCompliant = new Stack(); | ||
| Aspects.of(nonCompliant).add(new HIPAASecurityChecks()); | ||
| new TaskDefinition(nonCompliant, 'rTaskDef', { | ||
| compatibility: Compatibility.EC2, | ||
| networkMode: NetworkMode.HOST, | ||
| }).addContainer('rContainer', { | ||
| image: EcsOptimizedImage, | ||
| memoryReservationMiB: 42, | ||
| }); | ||
| const messages = SynthUtils.synthesize(nonCompliant).messages; | ||
| expect(messages).toContainEqual( | ||
| expect.objectContaining({ | ||
| entry: expect.objectContaining({ | ||
| data: expect.stringContaining( | ||
| 'HIPAA.Security-ECSTaskDefinitionUserForHostMode:' | ||
| ), | ||
| }), | ||
| }) | ||
| ); | ||
|
|
||
| const nonCompliant2 = new Stack(); | ||
| Aspects.of(nonCompliant2).add(new HIPAASecurityChecks()); | ||
| new TaskDefinition(nonCompliant2, 'rTaskDef', { | ||
| compatibility: Compatibility.EC2, | ||
| networkMode: NetworkMode.HOST, | ||
| }).addContainer('rContainer', { | ||
| image: EcsOptimizedImage, | ||
| memoryReservationMiB: 42, | ||
| user: 'ec2-user', | ||
| }); | ||
| const messages2 = SynthUtils.synthesize(nonCompliant).messages; | ||
| expect(messages2).toContainEqual( | ||
| expect.objectContaining({ | ||
| entry: expect.objectContaining({ | ||
| data: expect.stringContaining( | ||
| 'HIPAA.Security-ECSTaskDefinitionUserForHostMode:' | ||
| ), | ||
| }), | ||
| }) | ||
| ); | ||
|
|
||
| const nonCompliant3 = new Stack(); | ||
| Aspects.of(nonCompliant3).add(new HIPAASecurityChecks()); | ||
| new TaskDefinition(nonCompliant3, 'rTaskDef', { | ||
| compatibility: Compatibility.EC2, | ||
| networkMode: NetworkMode.HOST, | ||
| }).addContainer('rContainer', { | ||
| image: EcsOptimizedImage, | ||
| memoryReservationMiB: 42, | ||
| privileged: true, | ||
| user: '0', | ||
| }); | ||
| const messages3 = SynthUtils.synthesize(nonCompliant).messages; | ||
| expect(messages3).toContainEqual( | ||
| expect.objectContaining({ | ||
| entry: expect.objectContaining({ | ||
| data: expect.stringContaining( | ||
| 'HIPAA.Security-ECSTaskDefinitionUserForHostMode:' | ||
| ), | ||
| }), | ||
| }) | ||
| ); | ||
|
|
||
| const nonCompliant4 = new Stack(); | ||
| Aspects.of(nonCompliant4).add(new HIPAASecurityChecks()); | ||
| new TaskDefinition(nonCompliant4, 'rTaskDef', { | ||
| compatibility: Compatibility.EC2, | ||
| networkMode: NetworkMode.HOST, | ||
| }).addContainer('rContainer', { | ||
| image: EcsOptimizedImage, | ||
| memoryReservationMiB: 42, | ||
| privileged: true, | ||
| user: '0:root', | ||
| }); | ||
| const messages4 = SynthUtils.synthesize(nonCompliant).messages; | ||
| expect(messages4).toContainEqual( | ||
| expect.objectContaining({ | ||
| entry: expect.objectContaining({ | ||
| data: expect.stringContaining( | ||
| 'HIPAA.Security-ECSTaskDefinitionUserForHostMode:' | ||
| ), | ||
| }), | ||
| }) | ||
| ); | ||
|
|
||
| const nonCompliant5 = new Stack(); | ||
| Aspects.of(nonCompliant5).add(new HIPAASecurityChecks()); | ||
| const taskDef = new TaskDefinition(nonCompliant5, 'rTaskDef', { | ||
| compatibility: Compatibility.EC2, | ||
| networkMode: NetworkMode.HOST, | ||
| }); | ||
| taskDef.addContainer('rContainer', { | ||
| image: EcsOptimizedImage, | ||
| memoryReservationMiB: 42, | ||
| privileged: true, | ||
| user: 'not-root', | ||
| }); | ||
| taskDef.addContainer('rContainer2', { | ||
| image: EcsOptimizedImage, | ||
| memoryReservationMiB: 42, | ||
| }); | ||
| const messages5 = SynthUtils.synthesize(nonCompliant).messages; | ||
| expect(messages5).toContainEqual( | ||
| expect.objectContaining({ | ||
| entry: expect.objectContaining({ | ||
| data: expect.stringContaining( | ||
| 'HIPAA.Security-ECSTaskDefinitionUserForHostMode:' | ||
| ), | ||
| }), | ||
| }) | ||
| ); | ||
|
|
||
| const compliant = new Stack(); | ||
| Aspects.of(compliant).add(new HIPAASecurityChecks()); | ||
| new TaskDefinition(compliant, 'rTaskDef', { | ||
| compatibility: Compatibility.EC2, | ||
| networkMode: NetworkMode.HOST, | ||
| }); | ||
| new TaskDefinition(compliant, 'rTaskDef2', { | ||
| compatibility: Compatibility.EC2, | ||
| networkMode: NetworkMode.HOST, | ||
| }).addContainer('rContainer2', { | ||
| image: EcsOptimizedImage, | ||
| memoryReservationMiB: 42, | ||
| privileged: true, | ||
| user: 'not-root', | ||
| }); | ||
| new TaskDefinition(compliant, 'rTaskDef3', { | ||
| compatibility: Compatibility.EC2, | ||
| networkMode: NetworkMode.BRIDGE, | ||
| }).addContainer('rContainer3', { | ||
| image: EcsOptimizedImage, | ||
| memoryReservationMiB: 42, | ||
| }); | ||
| const messages6 = SynthUtils.synthesize(compliant).messages; | ||
| expect(messages6).not.toContainEqual( | ||
| expect.objectContaining({ | ||
| entry: expect.objectContaining({ | ||
| data: expect.stringContaining( | ||
| 'HIPAA.Security-ECSTaskDefinitionUserForHostMode:' | ||
| ), | ||
| }), | ||
| }) | ||
| ); | ||
| }); | ||
| }); |