Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): names generated using non-FIPS compliant algorithm #392

Merged
merged 20 commits into from
Nov 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/java/hello/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"dependencies": {
"cdk8s": "0.0.0",
"constructs": "3.0.4"
"constructs": "3.2.34"
},
"devDependencies": {
"cdk8s-cli": "0.0.0"
Expand Down
2 changes: 1 addition & 1 deletion examples/java/web-service/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"dependencies": {
"cdk8s": "0.0.0",
"constructs": "3.0.4"
"constructs": "3.2.34"
},
"devDependencies": {
"cdk8s-cli": "0.0.0"
Expand Down
2 changes: 1 addition & 1 deletion examples/python/crd/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"dependencies": {
"cdk8s": "0.0.0",
"constructs": "3.0.4"
"constructs": "3.2.34"
},
"devDependencies": {
"cdk8s-cli": "0.0.0"
Expand Down
2 changes: 1 addition & 1 deletion examples/python/hello/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"dependencies": {
"cdk8s": "0.0.0",
"constructs": "3.0.4"
"constructs": "3.2.34"
},
"devDependencies": {
"cdk8s-cli": "0.0.0"
Expand Down
2 changes: 1 addition & 1 deletion examples/python/web-service/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"dependencies": {
"cdk8s": "0.0.0",
"constructs": "3.0.4"
"constructs": "3.2.34"
},
"devDependencies": {
"cdk8s-cli": "0.0.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Array [
"apiVersion": "elasticsearch.k8s.elastic.co/v1",
"kind": "Elasticsearch",
"metadata": Object {
"name": "test-chart-elasticsearch-5921e846",
"name": "test-chart-elasticsearch-c819bb71",
},
"spec": Object {
"http": Object {
Expand Down Expand Up @@ -46,19 +46,19 @@ Array [
"apiVersion": "apps/v1",
"kind": "Deployment",
"metadata": Object {
"name": "test-chart-deployment-e606f14e",
"name": "test-chart-deployment-c8cfd183",
},
"spec": Object {
"replicas": 1,
"selector": Object {
"matchLabels": Object {
"cdk8s.deployment": "test-chart-Deployment-98e15317",
"cdk8s.deployment": "test-chart-Deployment-c8550d6d",
},
},
"template": Object {
"metadata": Object {
"labels": Object {
"cdk8s.deployment": "test-chart-Deployment-98e15317",
"cdk8s.deployment": "test-chart-Deployment-c8550d6d",
},
},
"spec": Object {
Expand All @@ -76,14 +76,14 @@ Array [
},
Object {
"name": "ELASTIC_ENDPOINT",
"value": "http://test-chart-elasticsearch-5921e846-es-http:9200",
"value": "http://test-chart-elasticsearch-c819bb71-es-http:9200",
},
Object {
"name": "ELASTIC_PASSWORD",
"valueFrom": Object {
"secretKeyRef": Object {
"key": "elastic",
"name": "test-chart-elasticsearch-5921e846-es-elastic-user",
"name": "test-chart-elasticsearch-c819bb71-es-elastic-user",
},
},
},
Expand All @@ -99,7 +99,7 @@ Array [
"volumeMounts": Array [
Object {
"mountPath": "/root",
"name": "configmap-test-chart-config-c3f7d3c0",
"name": "configmap-test-chart-config-c873bd48",
},
],
"workingDir": "/root",
Expand All @@ -108,9 +108,9 @@ Array [
"volumes": Array [
Object {
"configMap": Object {
"name": "test-chart-config-c3f7d3c0",
"name": "test-chart-config-c873bd48",
},
"name": "configmap-test-chart-config-c3f7d3c0",
"name": "configmap-test-chart-config-c873bd48",
},
],
},
Expand All @@ -121,7 +121,7 @@ Array [
"apiVersion": "v1",
"kind": "Service",
"metadata": Object {
"name": "test-chart-deployment-service-7f4c5401",
"name": "test-chart-deployment-service-c835a1d2",
},
"spec": Object {
"externalIPs": Array [],
Expand All @@ -132,7 +132,7 @@ Array [
},
],
"selector": Object {
"cdk8s.deployment": "test-chart-Deployment-98e15317",
"cdk8s.deployment": "test-chart-Deployment-c8550d6d",
},
"type": "ClusterIP",
},
Expand Down Expand Up @@ -210,7 +210,7 @@ function doSearch(uri, callback) {
},
"kind": "ConfigMap",
"metadata": Object {
"name": "test-chart-config-c3f7d3c0",
"name": "test-chart-config-c873bd48",
},
},
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"dependencies": {
"cdk8s": "0.0.0",
"cdk8s-plus-17": "0.0.0",
"constructs": "3.0.4"
"constructs": "3.2.34"
},
"devDependencies": {
"@types/jest": "^26.0.8",
Expand Down
2 changes: 1 addition & 1 deletion examples/typescript/cdk8s-plus-ingress/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"dependencies": {
"cdk8s": "0.0.0",
"cdk8s-plus-17": "0.0.0",
"constructs": "3.0.4"
"constructs": "3.2.34"
},
"devDependencies": {
"@types/node": "^14.0.27",
Expand Down
4 changes: 2 additions & 2 deletions examples/typescript/crd/__snapshots__/index.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Array [
"apiVersion": "jenkins.io/v1alpha2",
"kind": "Jenkins",
"metadata": Object {
"name": "hello-jenkins-6847f922",
"name": "hello-jenkins-c80d3a3b",
},
"spec": Object {
"jenkinsAPISettings": Object {
Expand All @@ -30,7 +30,7 @@ Array [
"apiVersion": "mattermost.com/v1alpha1",
"kind": "ClusterInstallation",
"metadata": Object {
"name": "hello-foo-6845e4bd",
"name": "hello-foo-c8398804",
},
"spec": Object {
"database": Object {
Expand Down
2 changes: 1 addition & 1 deletion examples/typescript/crd/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
"dependencies": {
"cdk8s": "0.0.0",
"constructs": "3.0.4"
"constructs": "3.2.34"
},
"devDependencies": {
"@types/jest": "^25.1.2",
Expand Down
4 changes: 2 additions & 2 deletions examples/typescript/hello/__snapshots__/index.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Array [
"apiVersion": "v1",
"kind": "Service",
"metadata": Object {
"name": "hello-service-9878228b",
"name": "hello-service-c8c17160",
},
"spec": Object {
"ports": Array [
Expand All @@ -25,7 +25,7 @@ Array [
"apiVersion": "apps/v1",
"kind": "Deployment",
"metadata": Object {
"name": "hello-deployment-c51e9e6b",
"name": "hello-deployment-c8c7fda7",
},
"spec": Object {
"replicas": 1,
Expand Down
2 changes: 1 addition & 1 deletion examples/typescript/hello/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
"dependencies": {
"cdk8s": "0.0.0",
"constructs": "3.0.4"
"constructs": "3.2.34"
},
"devDependencies": {
"@types/jest": "^25.1.2",
Expand Down
2 changes: 1 addition & 1 deletion examples/typescript/include-dashboard/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
},
"dependencies": {
"cdk8s": "0.0.0",
"constructs": "3.0.4"
"constructs": "3.2.34"
},
"devDependencies": {
"@types/jest": "^25.1.2",
Expand Down
4 changes: 2 additions & 2 deletions examples/typescript/podinfo/lib/deployment.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Construct, Node } from 'constructs';
import { Construct } from 'constructs';
import { ApiObject, Names } from 'cdk8s';
import { KubeDeployment, Affinity, Container, IntOrString } from '../imports/k8s';
import { Autoscaler, AutoscalingOptions } from './autoscaler';
Expand Down Expand Up @@ -90,7 +90,7 @@ export class Deployment extends Construct implements ISelector {
// labels

this.selector = {
deploymentId: Names.toLabelValue(Node.of(this).path),
deploymentId: Names.toLabelValue(this),
...options.labels
};

Expand Down
2 changes: 1 addition & 1 deletion examples/typescript/podinfo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
},
"dependencies": {
"cdk8s": "0.0.0",
"constructs": "3.0.4"
"constructs": "3.2.34"
},
"devDependencies": {
"@types/jest": "^25.1.2",
Expand Down
2 changes: 1 addition & 1 deletion examples/typescript/web-service/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
},
"dependencies": {
"cdk8s": "0.0.0",
"constructs": "3.0.4"
"constructs": "3.2.34"
},
"devDependencies": {
"@types/jest": "^25.1.2",
Expand Down
4 changes: 2 additions & 2 deletions examples/typescript/web-service/web-service.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Construct, Node } from 'constructs';
import { Construct } from 'constructs';
import { Names } from 'cdk8s';
import { KubeDeployment, KubeService, IntOrString } from './imports/k8s';

Expand Down Expand Up @@ -31,7 +31,7 @@ export class WebService extends Construct {

const port = options.port || 80;
const containerPort = options.containerPort || 8080;
const label = { app: Names.toLabelValue(Node.of(this).path) };
const label = { app: Names.toLabelValue(this) };
const replicas = options.replicas ?? 1;

new KubeService(this, 'service', {
Expand Down
2 changes: 1 addition & 1 deletion packages/cdk8s-cli/.projenrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const project = new TypeScriptLibraryProject({
deps: [
'cdk8s@0.0.0',
'codemaker',
`constructs@${common.versions.constructs}`,
`constructs@^${common.versions.constructs}`,
'fs-extra',
'jsii-srcmak',
'jsii-pacmak',
Expand Down
2 changes: 1 addition & 1 deletion packages/cdk8s-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@types/node": "^10.17.0",
"cdk8s": "0.0.0",
"codemaker": "^1.14.1",
"constructs": "3.0.4",
"constructs": "^3.2.34",
"fs-extra": "^8.1.0",
"jsii-pacmak": "^1.14.1",
"jsii-srcmak": "^0.1.36",
Expand Down
2 changes: 1 addition & 1 deletion packages/cdk8s-cli/src/cli/cmds/init.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import * as yargs from 'yargs';
const pkgroot = path.join(__dirname, '..', '..', '..');

const pkg = fs.readJsonSync(path.join(pkgroot, 'package.json'));
const constructsVersion = pkg.dependencies.constructs;
const constructsVersion = pkg.dependencies.constructs.replace('^', '');

const templatesDir = path.join(pkgroot, 'templates');
const availableTemplates = fs.readdirSync(templatesDir).filter(x => !x.startsWith('.'));
Expand Down
2 changes: 1 addition & 1 deletion packages/cdk8s-cli/templates/python-app/Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ verify_ssl = true
python_version = "3.7"

[packages]
constructs = "==3.0.4"
constructs = "~={{ constructs_version }}"
5 changes: 2 additions & 3 deletions packages/cdk8s-cli/templates/typescript-app/.hooks.sscaff.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
const { execSync } = require('child_process');
const { readFileSync } = require('fs');

const constructs_version = require('../../package.json').dependencies.constructs;

exports.post = ctx => {
const npm_cdk8s = ctx.npm_cdk8s;
const npm_cdk8s_plus = ctx.npm_cdk8s_plus;
const npm_cdk8s_cli = ctx.npm_cdk8s_cli;
const constructs_version = ctx.constructs_version;

if (!npm_cdk8s) { throw new Error(`missing context "npm_cdk8s"`); }
if (!npm_cdk8s_cli) { throw new Error(`missing context "npm_cdk8s_cli"`); }

installDeps([ npm_cdk8s, npm_cdk8s_plus, `constructs@${constructs_version}` ]);
installDeps([ npm_cdk8s, npm_cdk8s_plus, `constructs@^${constructs_version}` ]);
installDeps([
npm_cdk8s_cli,
'@types/node',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Object {
},
"dependencies": Object {
"cdk8s": "999.999.999",
"constructs": "3.0.4",
"constructs": "3.2.34",
},
"dependencyClosure": Object {
"cdk8s": Object {
Expand Down Expand Up @@ -253,7 +253,7 @@ Object {
},
"dependencies": Object {
"cdk8s": "999.999.999",
"constructs": "3.0.4",
"constructs": "3.2.34",
},
"dependencyClosure": Object {
"cdk8s": Object {
Expand Down Expand Up @@ -4318,7 +4318,7 @@ Object {
},
"dependencies": Object {
"cdk8s": "999.999.999",
"constructs": "3.0.4",
"constructs": "3.2.34",
},
"dependencyClosure": Object {
"cdk8s": Object {
Expand Down Expand Up @@ -17086,7 +17086,7 @@ Object {
},
"dependencies": Object {
"cdk8s": "999.999.999",
"constructs": "3.0.4",
"constructs": "3.2.34",
},
"dependencyClosure": Object {
"cdk8s": Object {
Expand Down Expand Up @@ -17329,7 +17329,7 @@ Object {
},
"dependencies": Object {
"cdk8s": "999.999.999",
"constructs": "3.0.4",
"constructs": "3.2.34",
},
"dependencyClosure": Object {
"cdk8s": Object {
Expand Down Expand Up @@ -17572,7 +17572,7 @@ Object {
},
"dependencies": Object {
"cdk8s": "999.999.999",
"constructs": "3.0.4",
"constructs": "3.2.34",
},
"dependencyClosure": Object {
"cdk8s": Object {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Object {
},
"dependencies": Object {
"cdk8s": "999.999.999",
"constructs": "3.0.4",
"constructs": "3.2.34",
},
"dependencyClosure": Object {
"cdk8s": Object {
Expand Down
Loading