fix(plus-17): L2 default child #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
suggested changes
Nov 18, 2020
|
|
||
| const chart = Testing.chart(); | ||
|
|
||
| expect(Node.of(new ConfigMap(chart, 'ConfigMap')).defaultChild).toBeTruthy(); |
There was a problem hiding this comment.
would it be better to assert instanceof KubeConfigMap or at least ApiObject.
BTW, should we rename ApiObject to KubeObject?
| @@ -142,6 +122,26 @@ function omitDuplicates(value: string, index: number, components: string[]) { | |||
| return value !== components[index-1]; | |||
| } | |||
|
|
|||
| function omitDefaultChild(value: string, _: number, __: string[]) { | |||
| return value.toLowerCase() !== 'resource' && value.toLowerCase() !== 'default'; | |||
There was a problem hiding this comment.
I believe it is actually case sensitive in constructs.
eladb
approved these changes
Nov 18, 2020
|
Your pull request will be updated and merged automatically (do not update manually). |
…to epolon/l2-default-child
|
Your pull request will be updated and merged automatically (do not update manually). |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All L1 children are now called
Resourceto mark them as the default child of the L2.BREAKING CHANGE: All L2 resource names will undergo a name change (e.g
test-chart-config-configmap-233db8e7->test-chart-config-c3f7d3c0)Resolves #373
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license