-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm provider/allow null values #1
Conversation
…scrubbing them during helm value merges
…values in values.yamls in the python api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @cdibble!
Overall, I think this change looks good. Just a couple items to address:
- Update helm.Release schema and regenerate SDKs
- Add a changelog entry
Once that's done, you can submit the pull request to the pulumi-kubernetes repo, and we can run this through CI testing.
Thanks for the feedback @lblackstone - I will address your comments and ping you when I've got an update ready. Sorry for the slow movement- I'm at a conference this week. I have an open ticket related to this and will address it as soon as I can :) |
…source schema. this commit is the result of running make ensure build install given the schema updates
@lblackstone Sorry for the delay. I think this is ready to go given your commentary. Do you want to take a look at this stage? Otherwise I can just PR to |
Proposed changes
I need to be able to pass
ingress.tls=[]
to the Apache Superset helm chart. This PR would add a boolean to allow null values throughmergeMaps
inhelm_release.go
and expose that option in the Python API.Related issues (optional)
Addresses pulumi#2089