Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm provider/allow null values #1

Merged
merged 8 commits into from
Oct 27, 2022
Merged

Conversation

cdibble
Copy link
Owner

@cdibble cdibble commented Sep 27, 2022

Proposed changes

I need to be able to pass ingress.tls=[] to the Apache Superset helm chart. This PR would add a boolean to allow null values through mergeMaps in helm_release.go and expose that option in the Python API.

Related issues (optional)

Addresses pulumi#2089

Copy link

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @cdibble!

Overall, I think this change looks good. Just a couple items to address:

  1. Update helm.Release schema and regenerate SDKs
  2. Add a changelog entry

Once that's done, you can submit the pull request to the pulumi-kubernetes repo, and we can run this through CI testing.

@cdibble
Copy link
Owner Author

cdibble commented Oct 4, 2022

Thanks for the feedback @lblackstone - I will address your comments and ping you when I've got an update ready. Sorry for the slow movement- I'm at a conference this week. I have an open ticket related to this and will address it as soon as I can :)

@cdibble cdibble self-assigned this Oct 4, 2022
@cdibble cdibble marked this pull request as ready for review October 25, 2022 16:26
@cdibble
Copy link
Owner Author

cdibble commented Oct 25, 2022

@lblackstone Sorry for the delay. I think this is ready to go given your commentary. Do you want to take a look at this stage? Otherwise I can just PR to pulumi/pulumi-kubernetes.

@cdibble cdibble merged commit d86e8b9 into master Oct 27, 2022
@cdibble cdibble deleted the helm_provider/allow_null_values branch October 27, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants