Move crd to crds dir #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Transmitt0r, to do this you'd have to edit the makefile to swap them around. This pull completely automagically so manually editing the files doesn't persist the changes |
|
@tomhobson hey, this PR is now 9 months old and I now understand a lot better why the CRD's are not part of the CRD directory (resources in the crd dir do only get applied once and then not updated, this would be confusing for people that use this chart). I'm still slightly annoyed that this means that this chart can't be used as a direct Helm-dependency, but applying CRD's should probably be done in a separate step from your application anyways since they are cluster-scoped resources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #31