handle ts type errors and warnings in UI build #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumengwang
approved these changes
May 6, 2022
de-lan
approved these changes
May 6, 2022
42549db to
beb4d67
Compare
beb4d67 to
00a7e0a
Compare
seanfeld
approved these changes
May 6, 2022
sumengwang
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle TS type errors and warnings in UI build
Description
This PR handles the two TS type errors I kept seeing while building the UI. They are not the ideal solutions but it's pretty much the best I could do at this point.
You can read more about the
buttonissue here. If/when we upgrade to MUI v5, we can useListItemButtoninstead of typeanyfor thebuttonprop.For the second one, it's hard to come up with an interface for the event obj as it depends on the props of the element it's coming from, so I just decided to give it a type
any.Edit: Decided to handle warnings as well
PR Type
Links
N/A
Test Plan
N/A
Screenshots
N/A