remove --openssl-legacy-provider flag #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9682556 to
bbee408
Compare
bbee408 to
e4015a6
Compare
radhikav1
approved these changes
Jan 29, 2025
| public void errorClassificationBannerIsShown() { | ||
| WaitHelper.waitForElementToBeDisplayed( | ||
| Helper.locateElementByTestId("features-pipelineDetails-errorDetails-errorCountMessage")); | ||
| public void errorClassificationBannerIsShown() throws InterruptedException { |
There was a problem hiding this comment.
Is the test failure related to the current change-set?
There was a problem hiding this comment.
No, it's unrelated. But this test step was flaky and it failed while I was working on this branch.
njbriggs
approved these changes
Jan 30, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
--openssl-legacy-providerflagDescription
After upgrading to node v22 from node v16,
--openssl-legacy-providerflag was added to fix the failing builds. The issue that caused the build failures were fixed in webpack v4.47.0. This PR upgrades webpack to the fixed version and removes the--openssl-legacy-providerflag.PR Type
Links
Jira: CDAP-21088
Test Plan
Existing builds and tests should pass
Screenshots
NA