Merge pull request #1283 from cdapio/error-classification-ui

Ux enhancements for error classification
cdapio · Jan 28, 2025 · 1123ad4 · 1123ad4
2 parents b6a119b + e42c17f
commit 1123ad4
Show file tree

Hide file tree

Showing 30 changed files with 925 additions and 379 deletions.
diff --git a/app/cdap/api/preview.js b/app/cdap/api/preview.js
@@ -22,6 +22,7 @@ const basepath = '/namespaces/:namespace/previews';
 
 export const MyPreviewApi = {
   getStageData: apiCreator(dataSrc, 'POST', 'REQUEST', `${basepath}/:previewId/tracers`),
+  getErrorDetails: apiCreator(dataSrc, 'POST', 'REQUEST', `${basepath}/:previewId/classify`),
 
   // logs
   nextLogs: apiCreator(dataSrc, 'GET', 'REQUEST', `${basepath}/:previewId/logs/next`),

diff --git a/app/cdap/components/LogViewer/TopPanel.tsx b/app/cdap/components/LogViewer/TopPanel.tsx
@@ -145,6 +145,7 @@ interface ITopPanelProps extends WithStyles<typeof styles> {
   getLatestLogs: () => void;
   setSystemLogs: (includeSystemLogs: boolean) => void;
   onClose?: () => void;
+  showStats?: boolean;
 }
 
 const TopPanelView: React.FC<ITopPanelProps> = ({
@@ -155,6 +156,7 @@ const TopPanelView: React.FC<ITopPanelProps> = ({
   setSystemLogs,
   onClose,
   loading,
+  showStats,
 }) => {
   const [includeSystemLogs, setLocalIncludeSystemLogs] = React.useState(
     dataFetcher.getIncludeSystemLogs()
@@ -183,9 +185,13 @@ const TopPanelView: React.FC<ITopPanelProps> = ({
   return (
     <div className={classes.root} data-cy="log-viewer-top-panel" data-testid="log-viewer-top-panel">
       <div className={classes.leftContainer}>
-        <Provider store={PipelineDetailStore}>
-          <RunLogsStatsChips />
-        </Provider>
+        {showStats ? (
+          <Provider store={PipelineDetailStore}>
+            <RunLogsStatsChips />
+          </Provider>
+        ) : (
+          <div />
+        )}
       </div>
       <div className={classes.rightContainer}>
         <Button

diff --git a/app/cdap/components/LogViewer/index.tsx b/app/cdap/components/LogViewer/index.tsx
@@ -84,6 +84,7 @@ interface ILogViewerProps extends WithStyles<typeof styles> {
   dataFetcher: DataFetcher;
   stopPoll?: boolean;
   onClose?: () => void;
+  showStats?: boolean;
 }
 
 interface ILogViewerState {
@@ -448,6 +449,7 @@ class LogViewerView extends React.PureComponent<ILogViewerProps, ILogViewerState
           setSystemLogs={this.setIncludeSystemLogs}
           onClose={this.props.onClose}
           loading={this.state.isFetching}
+          showStats={this.props.showStats}
         />
         <div className={classes.logsTableHeader}>
           <div className={classes.cell}>Time</div>