-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dxtbx_ext => dxtbx.__init__ #29
Comments
+1. Extension imports should only happen in their own module where they can be handled/patched. I wouldn't be surprised if there were root |
Anthchirp
added a commit
that referenced
this issue
May 22, 2019
Keep them available from the old location, w/ added DeprecationWarnings Fixes #29
candidate patch added |
Anthchirp
added a commit
that referenced
this issue
May 29, 2019
Keep them available from the old location, w/ added DeprecationWarnings Fixes #29
Anthchirp
added a commit
that referenced
this issue
Nov 13, 2019
Original deprecation happened in #29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently
in top level
dxtbx.__init__
Suggest moving this to
dxtbx.ext
with a one-release grace period with deprecation warnings.This would
dxtbx.*
namespace, and thereforeOpinions?
The text was updated successfully, but these errors were encountered: