Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dxtbx_ext => dxtbx.__init__ #29

Closed
Anthchirp opened this issue May 22, 2019 · 2 comments
Closed

dxtbx_ext => dxtbx.__init__ #29

Anthchirp opened this issue May 22, 2019 · 2 comments
Assignees

Comments

@Anthchirp
Copy link
Member

We currently

from dxtbx_ext import *

in top level dxtbx.__init__

Suggest moving this to dxtbx.ext with a one-release grace period with deprecation warnings.

This would

  • avoid polluting the dxtbx.* namespace, and therefore
  • make clear when extension methods are used, and
  • skip the automatic import of the extensions on importing dxtbx, which may not always be required

Opinions?

@ndevenish
Copy link
Collaborator

+1. Extension imports should only happen in their own module where they can be handled/patched. I wouldn't be surprised if there were root dxtbx names used that this moves, but it's better to have this separate even if we end up having to just explicitly import everything back into the dxtbx namespace.

Anthchirp added a commit that referenced this issue May 22, 2019
Keep them available from the old location, w/ added DeprecationWarnings

Fixes #29
@Anthchirp
Copy link
Member Author

candidate patch added

Anthchirp added a commit that referenced this issue May 29, 2019
Keep them available from the old location, w/ added DeprecationWarnings

Fixes #29
Anthchirp added a commit that referenced this issue Nov 13, 2019
Original deprecation happened in #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants