-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New "best cell" attribute for the Crystal model #142
Comments
I'm looking at this now and don't think we need any new methods or public attributes in |
fixed by b9d6bb2 |
Following dials/dials#670 we would like a "best cell" attribute on the
Crystal
model, which can be set by post-integration refinement by a program likedials.two_theta_refine
. It will be useful to keep this separate from theCrystal
's existing static A matrix, because that will have been used for spot prediction, whereas in the context ofdials.two_theta_refine
, the "best cell" will not have been refined jointly with crystal orientations U and therefore should not be used for spot prediction.I'm not completely happy with the name
best_cell
(is it really "best"?) and would welcome any alternatives.The text was updated successfully, but these errors were encountered: