This repository has been archived by the owner on Aug 23, 2024. It is now read-only.
Trigger build workflows for model on sqoop
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfsnow
commented
Nov 30, 2023
Comment on lines
+3
to
+14
| GH_API_REPOS=( | ||
| "https://api.github.com/repos/ccao-data/data-architecture" | ||
| "https://api.github.com/repos/ccao-data/data-architecture" | ||
| ) | ||
| GH_API_WORKFLOWS=( | ||
| "test_dbt_models.yaml" | ||
| "build_and_test_dbt.yaml" | ||
| ) | ||
| GH_API_WORKFLOW_INPUTS=( | ||
| "" | ||
| "model.vw_card_res_input model.vw_pin_condo_input" | ||
| ) |
There was a problem hiding this comment.
This is pretty hideous but works fine. Just iterates through the index of the arrays.
There was a problem hiding this comment.
[Nitpick, non-blocking] I love representing data in shell scripts 🙈 Perhaps a brief comment explaining the data structure would help with readability?
Comment on lines
+3
to
+14
| GH_API_REPOS=( | ||
| "https://api.github.com/repos/ccao-data/data-architecture" | ||
| "https://api.github.com/repos/ccao-data/data-architecture" | ||
| ) | ||
| GH_API_WORKFLOWS=( | ||
| "test_dbt_models.yaml" | ||
| "build_and_test_dbt.yaml" | ||
| ) | ||
| GH_API_WORKFLOW_INPUTS=( | ||
| "" | ||
| "model.vw_card_res_input model.vw_pin_condo_input" | ||
| ) |
There was a problem hiding this comment.
[Nitpick, non-blocking] I love representing data in shell scripts 🙈 Perhaps a brief comment explaining the data structure would help with readability?
scripts/dispatch-dbt-workflow.sh
Outdated
| if [ -z "${GH_API_WORKFLOW_INPUTS[$i]}" ]; then | ||
| echo '{"ref": "master"}' | ||
| else | ||
| echo "{\"ref\": \"master\", \"inputs\": {\"models\": \"${GH_API_WORKFLOW_INPUTS[$i]}\"}" |
There was a problem hiding this comment.
[Nitpick] Hm, I might be reading wrong here but I think we may be missing a closing brace:
Suggested change
| echo "{\"ref\": \"master\", \"inputs\": {\"models\": \"${GH_API_WORKFLOW_INPUTS[$i]}\"}" | |
| echo "{\"ref\": \"master\", \"inputs\": {\"models\": \"${GH_API_WORKFLOW_INPUTS[$i]}\"}}" |
There was a problem hiding this comment.
Nice catch. Fixed in 3bee4a2!
3e82a43 to
3bee4a2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds triggers to rebuild the main
modelinput views/tables on sqoop. Once ccao-data/data-architecture#255 is merged, this will rebuild the full table every morning once sqoop is finished running.