Remove local flagging script, use glue script since they are identical #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfsnow
reviewed
Oct 18, 2023
There was a problem hiding this comment.
This makes sense to me as long as you've confirmed it works via a Terraform test setup. @jeancochrane any quick thoughts?
jeancochrane
approved these changes
Oct 18, 2023
IIRC it was an artifact of the fact that we had to hash the flagging script and thus couldn't reference it via |
|
Yep that's correct, also because I had to have different code for each script because of the pandas mismatch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted local flagging scripts, and now the flagging script in the glue directory is used in our local scripts.
Closes #50