Add standard deviation requirement for ptax outliters #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfsnow
requested changes
Sep 26, 2023
glue/sales_val_flagging.py
Outdated
Comment on lines
100
to
103
| group_string = "_".join(groups) | ||
| df["ptax_flag_original"] = df["sale_filter_ptax_flag"] | ||
|
|
||
| df["sale_filter_ptax_flag"] = df.apply( |
There was a problem hiding this comment.
suggestion (non-blocking): Rather than overwriting the original column, I would just change the SQL ingest query to return sale_filter_ptax_flag AS ptax_flag_original, then create a new column named ptax_flag_w_deviation (or similar).
There was a problem hiding this comment.
Good call, should now be implemented.
dfsnow
approved these changes
Sep 26, 2023
Comment on lines
+103
to
+108
|
|
||
| df["ptax_flag_w_deviation"] = df["ptax_flag_original"] & ( | ||
| (df[f"sv_price_deviation_{group_string}"] >= ptax_sd[1]) | ||
| | (df[f"sv_price_deviation_{group_string}"] <= -ptax_sd[0]) | ||
| | (df[f"sv_price_per_sqft_deviation_{group_string}"] >= ptax_sd[1]) | ||
| | (df[f"sv_price_per_sqft_deviation_{group_string}"] <= -ptax_sd[0]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All scripts tested. Added parameter input for which standard deviations to use with ptax outlier. Original ptax flag preserved.
Closes #15