Make global-bind plugin safe in node envs #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When mousetrap loads in a non-dom environment, it bails early and doesn't set the Mousetrap global. Make the global-bind plugin detect that Mousetrap didn't initialize and bail itself.
5 tasks
1 task
|
👋 @ccampbell Any chance we could get this merged? Would help us out in WordPress-land (WordPress/gutenberg#16227 (comment)) 🙂 |
|
Sure thing. Merged and published a new release to NPM (1.6.4). |
|
Ahhhhh... this didn't actually work. The usage of the global |
blowery
added a commit
to blowery/mousetrap
that referenced
this pull request
Jan 23, 2020
Follow on from ccampbell#465, which missed the ReferenceError from trying to use the Mousetrap global at the end of the file.
romanrizzi
pushed a commit
to discourse/mousetrap
that referenced
this pull request
Mar 5, 2020
Make global-bind plugin safe in node envs
romanrizzi
pushed a commit
to discourse/mousetrap
that referenced
this pull request
Mar 5, 2020
Follow on from ccampbell#465, which missed the ReferenceError from trying to use the Mousetrap global at the end of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mousetrap loads in a non-dom environment, it bails early and doesn't set the Mousetrap global. Make the global-bind plugin detect that Mousetrap didn't initialize and bail itself.