Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no title on search results page #110

Closed
phette23 opened this issue Jul 2, 2020 · 0 comments
Closed

no title on search results page #110

phette23 opened this issue Jul 2, 2020 · 0 comments
Assignees
Labels

Comments

@phette23
Copy link
Member

phette23 commented Jul 2, 2020

e.g. see https://libraries.cca.edu/search/?q=test&searchType=services&page=1

The problem origin is that the search template inherits from the base.html template, which includes a head.html component that defines the title tag like so:

<title>
    {% block title %}
        {% if self.seo_title %}{{ self.seo_title }}{% else %}{{ self.title }}{% endif %}
    {% endblock %}
    {% block title_suffix %}| CCA Libraries{% endblock %}
</title>

but the search "page" is really a view without an underlying page object (all these self vars will be undefined, I believe) so we only get the title_suffix block "| CCA Libraries".

This is incredibly minor but still unideal.

@phette23 phette23 added the bug label Jul 2, 2020
@phette23 phette23 self-assigned this Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant