Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmsdk: fetch real time data in the API #63

Merged
merged 1 commit into from
Jan 25, 2024
Merged

vmsdk: fetch real time data in the API #63

merged 1 commit into from
Jan 25, 2024

Conversation

Ruoyu-y
Copy link
Member

@Ruoyu-y Ruoyu-y commented Jan 16, 2024

  • Re-do the processing each time calling the API
  • fix minor typo

@Ruoyu-y Ruoyu-y changed the title vmsdk: fetch real time data in the API [DO NOT MERGE IMMEDIATELY] vmsdk: fetch real time data in the API Jan 16, 2024
@Ruoyu-y
Copy link
Member Author

Ruoyu-y commented Jan 16, 2024

According to the discussion with Ruomeng, Hairong and Xiaocheng, only do the processing at init time means the measurement/event logs won't be real time data if user init the vmsdk once and use multiple times at different timing(init, re-attest, etc).
Currently, we are binding the life cycle of vmsdk with cvm, both stateless. But the core attributes of cvm like event log, quote must be stateful(considering the container measurement case). To be aligned among all attributes, do re-processing every time the API get called.

ruomengh
ruomengh approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@ruomengh ruomengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ruoyu-y Ruoyu-y force-pushed the enhance_arch branch 3 times, most recently from 629914b to 6263343 Compare January 25, 2024 01:45
@Ruoyu-y Ruoyu-y merged commit b2d57c7 into cc-api:main Jan 25, 2024
4 checks passed
@Ruoyu-y Ruoyu-y changed the title [DO NOT MERGE IMMEDIATELY] vmsdk: fetch real time data in the API vmsdk: fetch real time data in the API Jan 25, 2024
@Ruoyu-y Ruoyu-y deleted the enhance_arch branch January 25, 2024 02:17
@Ruoyu-y
vmsdk: fetch real time data in the API
6263343 
* Re-do the processing each time calling the API
* fix minor typo

Signed-off-by: Ruoyu Ying <ruoyu.ying@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruomengh ruomengh ruomengh approved these changes

@kenplusplus kenplusplus Awaiting requested review from kenplusplus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ruoyu-y @ruomengh